Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote: > > [...] > = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > > + if (!dsi1) { > > + dev_err(dev, "cannot get secondary DSI > > node.\n"); > > + return

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-09 Thread Konrad Dybcio
[...] = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > + if (!dsi1) { > + dev_err(dev, "cannot get secondary DSI node.\n"); > + return -ENODEV; > + } > + > + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 01:33:39PM +0100, Konrad Dybcio wrote: > > phy-type: > description: D-PHY (default) or C-PHY mode > enum: [ 10, 11 ] > default: 10 > > try setting that to 11 under your DSI PHYs (or one? not sure). I already used phy-type = before, this equate to

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Konrad Dybcio
On 8.03.2023 12:53, Jianhua Lu wrote: > On Wed, Mar 08, 2023 at 12:13:53PM +0100, Konrad Dybcio wrote: >> >> >> On 8.03.2023 05:37, Jianhua Lu wrote: >>> Add a driver for panels using the Novatek NT36523 display driver IC. >>> >>> Signed-off-by: Jianhua Lu >>> --- >>> Changes in v3: >>> -

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 12:13:53PM +0100, Konrad Dybcio wrote: > > > On 8.03.2023 05:37, Jianhua Lu wrote: > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v3: > > - Refactor source code > > > > Changes in v2:

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Konrad Dybcio
On 8.03.2023 05:37, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. > > Signed-off-by: Jianhua Lu > --- > Changes in v3: > - Refactor source code > > Changes in v2: > - Refactor and clean up source code This is a veeery vague changelog, akin to

[PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v3: - Refactor source code Changes in v2: - Refactor and clean up source code MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig