On Lu, 2019-06-24 at 13:12 -0300, Fabio Estevam wrote:
> Caution: EXT Email
>
> Hi Robert,
>
> On Mon, Jun 24, 2019 at 4:44 AM Robert Chiras
> wrote:
>
> >
> > >
> > > You did not handle the "power" regulator.
> > There is no need for a power regulator.
> I am sure the panel requires power
Hi Robert,
On Mon, Jun 24, 2019 at 4:44 AM Robert Chiras wrote:
> > You did not handle the "power" regulator.
> There is no need for a power regulator.
I am sure the panel requires power to be applied so that it can work :-)
> > Can't you simply remove them?
> The reset gpio pin is shared
Hi Fabio,
Thanks for your feedback. I will handle them all, but for the pm_ops I
have some comments. See inline.
On Vi, 2019-06-21 at 10:59 -0300, Fabio Estevam wrote:
> Hi Robert,
>
> On Thu, Jun 20, 2019 at 10:31 AM Robert Chiras > wrote:
>
> >
> > +fail:
> > + if (rad->reset)
> > +
Hi Robert,
On Thu, Jun 20, 2019 at 10:31 AM Robert Chiras wrote:
> +fail:
> + if (rad->reset)
> + gpiod_set_value_cansleep(rad->reset, 1);
gpiod_set_value_cansleep() can handle NULL, so no need for the if() check.
> +static const struct display_timing rad_default_timing =
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
protocol).
Signed-off-by: Robert Chiras
Reviewed-by: Sam Ravnborg
---
MAINTAINERS | 6 +
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile| 1
