Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-11-06 Thread Maxime Ripard
On Mon, Nov 05, 2018 at 09:23:08PM +0800, Icenowy Zheng wrote: > 在 2018-10-08一的 11:21 +0200,Maxime Ripard写道: > > On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > > > If tcon->panel pointer is NULL, trying to dereference from it > > > (i.e. tcon->panel->connector) will cause a null

Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-11-06 Thread Icenowy Zheng
在 2018-10-08一的 11:21 +0200,Maxime Ripard写道: > On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > > If tcon->panel pointer is NULL, trying to dereference from it > > (i.e. tcon->panel->connector) will cause a null pointer > > dereference. > > > > Add tcon->panel null pointer check be

Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-12 Thread Chen-Yu Tsai
On Mon, Oct 8, 2018 at 5:21 PM Maxime Ripard wrote: > > On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > > If tcon->panel pointer is NULL, trying to dereference from it > > (i.e. tcon->panel->connector) will cause a null pointer dereference. > > > > Add tcon->panel null pointer ch

Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-08 Thread Maxime Ripard
On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > If tcon->panel pointer is NULL, trying to dereference from it > (i.e. tcon->panel->connector) will cause a null pointer dereference. > > Add tcon->panel null pointer check before calling > sun4i_tcon0_mode_set_dithering(). > > Sign

[PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-05 Thread Giulio Benetti
If tcon->panel pointer is NULL, trying to dereference from it (i.e. tcon->panel->connector) will cause a null pointer dereference. Add tcon->panel null pointer check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add ditherin