Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 21:52, Dmitry Osipenko пишет: ... >> May I also recommend switching to the DRM panel bridge helper ? It will >> simplify the code. > > Could you please clarify what is the "DRM panel bridge helper"? > > I think we won't need any additional helpers after switching to the > bridge

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 23:50, Laurent Pinchart пишет: > Hi Dmitry, > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: >> 16.04.2020 21:52, Dmitry Osipenko пишет: >> ... May I also recommend switching to the DRM panel bridge helper ? It will simplify the code. >>> >>> Could you

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
17.04.2020 00:39, Laurent Pinchart пишет: > Hi Dmitry, > > On Fri, Apr 17, 2020 at 12:15:33AM +0300, Dmitry Osipenko wrote: >> 16.04.2020 23:50, Laurent Pinchart пишет: >>> On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: 16.04.2020 21:52, Dmitry Osipenko пишет: ...

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
16.04.2020 20:41, Laurent Pinchart пишет: ... >> +if (output->bridge) { >> +err = drm_bridge_attach(>encoder, output->bridge, >> +NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > Using DRM_BRIDGE_ATTACH_NO_CONNECTOR is definitely the way to go, but >

[PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-17 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph that involves LVDS encoder bridge, This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model display hardware properly. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Laurent Pinchart
Hi Dmitry, On Fri, Apr 17, 2020 at 12:15:33AM +0300, Dmitry Osipenko wrote: > 16.04.2020 23:50, Laurent Pinchart пишет: > > On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > >> 16.04.2020 21:52, Dmitry Osipenko пишет: > >> ... > May I also recommend switching to the DRM

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Laurent Pinchart
Hi Dmitry, On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Sam Ravnborg
Hi Dimitry. On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge

Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-04-16 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Thu, Apr 16, 2020 at 08:24:05PM +0300, Dmitry Osipenko wrote: > Newer Tegra device-trees will specify a video output graph that involves > LVDS encoder bridge, This patch adds support for the LVDS encoder bridge > to the RGB output, allowing us to model