Marcus Folkesson writes:
> Hello Javier,
>
> On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
>> > The controller has a SPI, I2C and 8bit parallel in
Hello Javier,
On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI, I2C and 8bit parallel interface, this
> > driver is for the I2
Marcus Folkesson writes:
Hello Marcus,
[...]
>> >
>> > A comment for v4:
>> >
>> > I think I will go for a property in the device tree. I've implemented
>> > board entries as above, but I'm not satisfied for two reasons:
>> >
>> > 1. All other properties like display size and resolution are alr
On Fri, Apr 11, 2025 at 10:26:47AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >> static const struct of_device_id st7571_of_match[] = {
> >>/* monochrome displays */
> >>{
> >>.compatible = "sinocrystal,sc128128012-v01",
Marcus Folkesson writes:
Hello Marcus,
[...]
>> static const struct of_device_id st7571_of_match[] = {
>> /* monochrome displays */
>> {
>> .compatible = "sinocrystal,sc128128012-v01",
>> .data = monochrome_formats,
>> },
>> ...
>> /* grayscale d
On Wed, 9 Apr 2025 at 16:16, Javier Martinez Canillas
wrote:
> Marcus Folkesson writes:
> > On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
>
> [...]
>
> >>
> >> Likely you will need to define more stuff to be specific for each entry,
> >> maybe
> >> you will need diffe
Hello,
On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >>
> >> That's a god question, I don't really know...
> >>
> >> But fbdev does support XRGB, which may be another good reason to add
> >> it and mak
Marcus Folkesson writes:
> Hello Javier,
>
> Thank you for your review and suggestions.
>
> On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
>> > The
Marcus Folkesson writes:
> Hello Javier,
>
> On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
[...]
>>
>> Likely you will need to define more stuff to be specific for each entry,
>> maybe
>> you will need different primary plane update handlers too. Similar to how I
Marcus Folkesson writes:
Hello Marcus,
[...]
>>
>> That's a god question, I don't really know...
>>
>> But fbdev does support XRGB, which may be another good reason to add
>> it and make it the default format. Yes, it will cause an unnecessary pixel
>> format conversion but the I2C transp
Hello Javier,
On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> [...]
>
> >>
> >> That's a god question, I don't really know...
> >>
> >> But fbdev does support XRGB, which may be another good reason to add
> >> it
Hi
Am 08.04.25 um 16:58 schrieb Marcus Folkesson:
Hi,
On Tue, Apr 08, 2025 at 03:57:22PM +0200, Thomas Zimmermann wrote:
Hi
Am 08.04.25 um 15:20 schrieb Marcus Folkesson:
[...]
+static int st7571_set_pixel_format(struct st7571_device *st7571,
+ u32 pixel_form
Hello Javier,
On Wed, Apr 09, 2025 at 08:11:23AM +0200, Javier Martinez Canillas wrote:
[...]
> >> > +static int st7571_set_pixel_format(struct st7571_device *st7571,
> >> > + u32 pixel_format)
> >> > +{
> >> > +switch (pixel_format) {
> >> > +cas
Hi,
On Tue, Apr 08, 2025 at 03:57:22PM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 08.04.25 um 15:20 schrieb Marcus Folkesson:
> [...]
> > >
> > > > +static int st7571_set_pixel_format(struct st7571_device *st7571,
> > > > + u32 pixel_format)
> > > > +{
> > > > +
Hi
Am 08.04.25 um 15:20 schrieb Marcus Folkesson:
[...]
+static int st7571_set_pixel_format(struct st7571_device *st7571,
+ u32 pixel_format)
+{
+ switch (pixel_format) {
+ case DRM_FORMAT_C1:
+ return st7571_set_color_mode(st7571,
ST
Hello Javier,
Thank you for your review and suggestions.
On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson writes:
>
> Hello Marcus,
>
> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> > The controller has a SPI, I2C and 8bit paral
Thomas Zimmermann writes:
> Hi,
>
> lots of good points in the review.
>
> Am 08.04.25 um 12:44 schrieb Javier Martinez Canillas:
> [...]
>>> Reviewed-by: Thomas Zimmermann
>>> Signed-off-by: Marcus Folkesson
>>> ---
>>> drivers/gpu/drm/tiny/Kconfig | 11 +
>>> drivers/gpu/drm/tiny/Mak
Hi,
lots of good points in the review.
Am 08.04.25 um 12:44 schrieb Javier Martinez Canillas:
[...]
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 11 +
drivers/gpu/drm/tiny/Makefile | 1 +
drivers/gpu/drm/tiny/st7571-i2c.c |
Marcus Folkesson writes:
Hello Marcus,
> Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> The controller has a SPI, I2C and 8bit parallel interface, this
> driver is for the I2C interface only.
>
I would structure the driver differently. For example, what was done
for the Solom
Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
The controller has a SPI, I2C and 8bit parallel interface, this
driver is for the I2C interface only.
Reviewed-by: Thomas Zimmermann
Signed-off-by: Marcus Folkesson
---
drivers/gpu/drm/tiny/Kconfig | 11 +
drivers/gpu/drm/tin
20 matches
Mail list logo
