Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-27 Thread Sergey Senozhatsky
On (06/26/18 20:36), Hans de Goede wrote: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Reviewed-by: Daniel Vetter > Signed-off-by: Hans de Goede Reviewed-by: Sergey Senozhatsky

[PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-26 Thread Hans de Goede
Replace comments about places where the console lock should be held with calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Reviewed-by: Daniel Vetter Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patchset Changes in v4: -Keep the comments about

Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-26 Thread Hans de Goede
Hi, On 26-06-18 16:47, Steven Rostedt wrote: On Tue, 26 Jun 2018 15:55:34 +0200 Hans de Goede wrote: Replace comments about places where the console lock should be held with calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Why replace the comments? I prefer them, even

Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-26 Thread Steven Rostedt
On Tue, 26 Jun 2018 15:55:34 +0200 Hans de Goede wrote: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Why replace the comments? I prefer them, even with the WARN. The reason is, when using

Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-26 Thread Daniel Vetter
On Tue, Jun 26, 2018 at 03:55:34PM +0200, Hans de Goede wrote: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Signed-off-by: Hans de Goede > --- > Changes in v3: > -New patch in v3 of this

[PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-06-26 Thread Hans de Goede
Replace comments about places where the console lock should be held with calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Signed-off-by: Hans de Goede --- Changes in v3: -New patch in v3 of this patchset --- drivers/video/fbdev/core/fbcon.c | 18 +++--- 1 file