Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-04 Thread Sam Ravnborg
Hi Kevin, > 1) Get an un-accelerated driver merged without new uapi, ioctls, etc. All > you need is there already. We already agreed to take the code mostly as-is > and do the cleanups later on. > > 2a) Stay around on dri-devel, send improvements and fixes for the merged > code. > > 2b) In

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-04 Thread Thomas Zimmermann
:38 AM From: "Thomas Zimmermann" To: "Kevin Brace" Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h Hi Am 02.08.22 um 05:45 schrieb Kevin Brace: Hi Thomas, I hope I am comprehending this right. Yes, I am adding 3 new uAPI calls, not 6 of them.

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Kevin Brace
) graphics hardware. Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Tuesday, August 02, 2022 at 4:38 AM > From: "Thomas Zimmermann" > To: "Kevin Brace" > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [PATCH v3

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Kevin Brace
"Thomas Zimmermann" , dri-devel@lists.freedesktop.org > Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h > > Hi Kevin, > > > > OpenChrome DDX carries lots of legacy code. > > > > https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_drm.h?h=m

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Thomas Zimmermann
-kms.html#dumb-buffer-objects Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com Sent: Monday, August 01, 2022 at 11:49 AM From: "Thomas Zimmermann" To: "Kevin Brace" Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 26/32] drm/via: Add

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-02 Thread Sam Ravnborg
Hi Kevin, > > OpenChrome DDX carries lots of legacy code. > > https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_drm.h?h=main=dc661c59257e855cd9b29c14b91a8ee2d9b86ccb > > There is a requirement to use the same via_drm.h with both DDX and DRM. > Hence, I need to keep a

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Kevin Brace
t; To: "Kevin Brace" > Cc: dri-devel@lists.freedesktop.org > Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h > > Hi Kevin > > Am 31.07.22 um 00:48 schrieb Kevin Brace: > > Hi Thomas, > > > > I cannot drop the older DRI1 based uAPI calls. > &

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Kevin Brace
DRI1 definitions inside via_drm.h. Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Monday, August 01, 2022 at 7:40 AM > From: "Sam Ravnborg" > To: "Kevin Brace" > Cc: "Thomas Zimmermann" , dri-devel@lists.free

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Thomas Zimmermann
Kevin Brace" Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h Hi Am 26.07.22 um 01:53 schrieb Kevin Brace: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace --- include/uapi/drm/via_drm.h | 35 +++ 1 file changed, 31 insertions(+), 4 dele

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Sam Ravnborg
Hi Kevin, > I cannot drop the older DRI1 based uAPI calls. > This is because include/uapi/drm/via_drm.h needs to retain backward > compatibility with the existing OpenChrome DDX's XvMC library > (it gets compiled when OpenChrome DDX is built) and likely with the > existing DDX Xv code as well. >

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-30 Thread Kevin Brace
back to userspace. Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Tuesday, July 26, 2022 at 10:41 AM > From: "Sam Ravnborg" > To: "Kevin Brace" > Cc: dri-devel@lists.freedesktop.org, "Kevin Brace" >

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-30 Thread Kevin Brace
/ reasoning is okay with you. Regards, Kevin Brace Brace Computer Laboratory blog https://bracecomputerlab.com > Sent: Tuesday, July 26, 2022 at 11:24 AM > From: "Thomas Zimmermann" > To: "Kevin Brace" , dri-devel@lists.freedesktop.org > Cc: "Kevin Brace" &g

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-28 Thread Kevin Brace
; From: "Dave Airlie" > To: "Thomas Zimmermann" > Cc: "Sam Ravnborg" , "Kevin Brace" , > "Kevin Brace" , "dri-devel" > > Subject: Re: [PATCH v3 26/32] drm/via: Add via_drm.h > > On Wed, 27 Jul 2022 at 04:18,

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-27 Thread Thomas Zimmermann
Hi Am 26.07.22 um 22:20 schrieb Dave Airlie: On Wed, 27 Jul 2022 at 04:18, Thomas Zimmermann wrote: Hi Am 26.07.22 um 19:41 schrieb Sam Ravnborg: Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace It

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Dave Airlie
On Wed, 27 Jul 2022 at 04:18, Thomas Zimmermann wrote: > > Hi > > Am 26.07.22 um 19:41 schrieb Sam Ravnborg: > > Hi Kevin. > > > > On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: > >> From: Kevin Brace > >> > >> Changed the uAPI. > >> > >> Signed-off-by: Kevin Brace > > > > It

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 01:53 schrieb Kevin Brace: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace --- include/uapi/drm/via_drm.h | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/via_drm.h

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 19:41 schrieb Sam Ravnborg: Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace It would be great to have the new extensions to the UAPI documented using kernel-doc. As an example see:

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Sam Ravnborg
Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: > From: Kevin Brace > > Changed the uAPI. > > Signed-off-by: Kevin Brace It would be great to have the new extensions to the UAPI documented using kernel-doc. As an example see: vc4_drm.h There are a lot of UAPI that is

[PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-25 Thread Kevin Brace
From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace --- include/uapi/drm/via_drm.h | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h index a1e125d42208..e9da45ce130a