Re: [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-24 Thread cuigaosheng
If you're going to update the other patches to use IS_ERR_OR_NULL() please do so here too. You can keep my R-b for that change. Thanks for taking time to review the patch. I have update the patch set and add this change to v5. On 2023/7/21 18:24, Liviu Dudau wrote: Hi Gaosheng, On Fri, Jul

Re: [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-21 Thread Liviu Dudau
Hi Gaosheng, On Fri, Jul 14, 2023 at 09:48:20AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") > Signed-off-by:

[PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-13 Thread Gaosheng Cui
The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui Reviewed-by: Liviu Dudau ---