Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-18 Thread 林睿祥

RE: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-17 Thread David Laight
From: Jason-JH Lin > Sent: 14 July 2023 07:46 > > Hi CK, > > Thanks for the reviews. > > On Fri, 2023-07-14 at 05:45 +, CK Hu (胡俊光) wrote: > > Hi, Jason: > > > > On Wed, 2023-06-21 at 18:22 +0800, Jason-JH.Lin wrote: > > > 1. Add casting before assign to avoid the unintentional integer > > >

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-13 Thread 林睿祥

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-13 Thread 胡俊光

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-12 Thread Alexandre Mergnat
On 22/06/2023 10:02, Jason-JH Lin (林睿祥) wrote: drm_plane_state *new_state, > dma_addr_t addr; > dma_addr_t hdr_addr = 0; > unsigned int hdr_pitch = 0; > +int offset; I agree with Angelo, please set offset as unsigned. I think offset should be unsigned, but since src.x1 and src.y1 are

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-06-22 Thread 林睿祥

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-06-21 Thread Alexandre Mergnat
On 21/06/2023 12:22, Jason-JH.Lin wrote: 1. Add casting before assign to avoid the unintentional integer overflow or unintended sign extension. 2. Add a int varriable for multiplier calculation instead of calculating different types multiplier with dma_addr_t varriable directly. Fixes

[PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-06-21 Thread Jason-JH . Lin
1. Add casting before assign to avoid the unintentional integer overflow or unintended sign extension. 2. Add a int varriable for multiplier calculation instead of calculating different types multiplier with dma_addr_t varriable directly. Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane