Re: [Nouveau] [PATCH v3 4/4] drm/nouveau: Move PBN and VCPI allocation into nv50_head_atom

2019-02-04 Thread Ben Skeggs
On Sat, 2 Feb 2019 at 10:20, Lyude Paul wrote: > > Atomic checks should never modify anything outside of the state that > they're passed in. Unfortunately this appears to be exactly what we're > doing in nv50_msto_atomic_check() where we update mstc->pbn every time > the function is called. This

[PATCH v3 4/4] drm/nouveau: Move PBN and VCPI allocation into nv50_head_atom

2019-02-01 Thread Lyude Paul
Atomic checks should never modify anything outside of the state that they're passed in. Unfortunately this appears to be exactly what we're doing in nv50_msto_atomic_check() where we update mstc->pbn every time the function is called. This hasn't caused any bugs yet, but it needs to be fixed in