Re: [PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-28 Thread Steven Price
On 28/08/2019 13:35, Rob Herring wrote: > On Wed, Aug 28, 2019 at 5:55 AM Steven Price wrote: >> >> On 26/08/2019 23:33, Rob Herring wrote: >>> Currently, page tables are freed without disabling the address space first. >>> This probably is fine as we'll switch to new page tables when the address

Re: [PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-28 Thread Rob Herring
On Wed, Aug 28, 2019 at 5:55 AM Steven Price wrote: > > On 26/08/2019 23:33, Rob Herring wrote: > > Currently, page tables are freed without disabling the address space first. > > This probably is fine as we'll switch to new page tables when the address > > space is allocated again and runtime PM

Re: [PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-28 Thread Steven Price
On 26/08/2019 23:33, Rob Herring wrote: > Currently, page tables are freed without disabling the address space first. > This probably is fine as we'll switch to new page tables when the address > space is allocated again and runtime PM suspend will reset the GPU > clearing the registers. However,

Re: [PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-27 Thread Robin Murphy
On 26/08/2019 23:33, Rob Herring wrote: Currently, page tables are freed without disabling the address space first. This probably is fine as we'll switch to new page tables when the address space is allocated again and runtime PM suspend will reset the GPU clearing the registers. However, it's

[PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-26 Thread Rob Herring
Currently, page tables are freed without disabling the address space first. This probably is fine as we'll switch to new page tables when the address space is allocated again and runtime PM suspend will reset the GPU clearing the registers. However, it's better to clean up after ourselves. There