Re: [PATCH v4] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-13 Thread Mohamed Ahmed
Hey, Understood. Thanks a lot and sorry for any inconvenience. Mohamed On Mon, May 13, 2024 at 11:28 PM Danilo Krummrich wrote: > Hi Mohamed, > > Thank you for fixing this up! > > On 5/9/24 22:43, Mohamed Ahmed wrote: > > Allows PTE kind and tile mode on BO create with VM_BIND, > > and adds a

Re: [PATCH v4] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-13 Thread Danilo Krummrich
Hi Mohamed, Thank you for fixing this up! On 5/9/24 22:43, Mohamed Ahmed wrote: Allows PTE kind and tile mode on BO create with VM_BIND, and adds a GETPARAM to indicate this change. This is needed to support It's usually better to use imperative verb form for commit messages. No need to send

Re: [PATCH v4] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-09 Thread Faith Ekstrand
On Thu, May 9, 2024 at 3:44 PM Mohamed Ahmed < mohamedahmedegypt2...@gmail.com> wrote: > Allows PTE kind and tile mode on BO create with VM_BIND, > and adds a GETPARAM to indicate this change. This is needed to support > modifiers in NVK and ensure correctness when dealing with the nouveau > GL

[PATCH v4] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-09 Thread Mohamed Ahmed
Allows PTE kind and tile mode on BO create with VM_BIND, and adds a GETPARAM to indicate this change. This is needed to support modifiers in NVK and ensure correctness when dealing with the nouveau GL driver. The userspace modifiers implementation this is for can be found here: