Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-28 Thread Gerd Hoffmann
> > > stolen memory is where the fb physically resides. the pci bar is how > > > you access it (as long as you take all the pci bars). From a quick > > > look i915 and pci version of remove_conflicting_fb matched. > > > > Well, it is > > > > ap->ranges[0].base = ggtt->gmadr.start; > >

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-28 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 09:34:09AM +0100, Gerd Hoffmann wrote: > On Fri, Feb 22, 2019 at 06:20:11PM +0100, Daniel Vetter wrote: > > On Fri, Feb 22, 2019 at 12:03 PM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > - /* > > > > > -* WARNING: Apparently we must kick fbdev drivers before

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-25 Thread Gerd Hoffmann
On Fri, Feb 22, 2019 at 06:20:11PM +0100, Daniel Vetter wrote: > On Fri, Feb 22, 2019 at 12:03 PM Gerd Hoffmann wrote: > > > > Hi, > > > > > > - /* > > > > -* WARNING: Apparently we must kick fbdev drivers before vgacon, > > > > -* otherwise the vga fbdev driver falls over. > > > > -

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-22 Thread Daniel Vetter
On Fri, Feb 22, 2019 at 12:03 PM Gerd Hoffmann wrote: > > Hi, > > > > - /* > > > -* WARNING: Apparently we must kick fbdev drivers before vgacon, > > > -* otherwise the vga fbdev driver falls over. > > > -*/ > > > ret = i915_kick_out_firmware_fb(dev_priv); > > > > This needs

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-22 Thread Gerd Hoffmann
Hi, > > - /* > > -* WARNING: Apparently we must kick fbdev drivers before vgacon, > > -* otherwise the vga fbdev driver falls over. > > -*/ > > ret = i915_kick_out_firmware_fb(dev_priv); > > This needs to be replaced with a call to >

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-22 Thread Daniel Vetter
On Fri, Feb 22, 2019 at 08:16:03AM +0100, Gerd Hoffmann wrote: > Also rename it and call it automatically from > drm_fb_helper_remove_conflicting_pci_framebuffers() Yeah this looks neat. > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_fb_helper.h | 14 +++--- >

[PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-21 Thread Gerd Hoffmann
Also rename it and call it automatically from drm_fb_helper_remove_conflicting_pci_framebuffers() Signed-off-by: Gerd Hoffmann --- include/drm/drm_fb_helper.h | 14 +++--- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 43