Re: [PATCH v4 1/7] drm/format-helper: Cache buffers with struct drm_format_conv_state

2023-10-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > [...] >> >> I'm confused, the copy helper is the same than init. What's the point of >> this function ? Why not just call drm_format_conv_state_init() from the >> __drm_gem_duplicate_shadow_plane_state() function in the next patch ? > > I guess that deserves a

Re: [PATCH v4 1/7] drm/format-helper: Cache buffers with struct drm_format_conv_state

2023-10-05 Thread Thomas Zimmermann
Hi Am 05.10.23 um 15:18 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Hold temporary memory for format conversion in an instance of struct drm_format_conv_state. Update internal helpers of DRM's format-conversion code accordingly. Drivers will later be able to

Re: [PATCH v4 1/7] drm/format-helper: Cache buffers with struct drm_format_conv_state

2023-10-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hold temporary memory for format conversion in an instance of struct > drm_format_conv_state. Update internal helpers of DRM's format-conversion > code accordingly. Drivers will later be able to maintain this cache by > themselves. > > Besides caching,

Re: [PATCH v4 1/7] drm/format-helper: Cache buffers with struct drm_format_conv_state

2023-10-05 Thread Noralf Trønnes
On 10/5/23 11:04, Thomas Zimmermann wrote: > Hold temporary memory for format conversion in an instance of struct > drm_format_conv_state. Update internal helpers of DRM's format-conversion > code accordingly. Drivers will later be able to maintain this cache by > themselves. > > Besides

[PATCH v4 1/7] drm/format-helper: Cache buffers with struct drm_format_conv_state

2023-10-05 Thread Thomas Zimmermann
Hold temporary memory for format conversion in an instance of struct drm_format_conv_state. Update internal helpers of DRM's format-conversion code accordingly. Drivers will later be able to maintain this cache by themselves. Besides caching, struct drm_format_conv_state will be useful to hold