Re: [PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-09 Thread Teres Alexis, Alan Previn
Nit: wish some of those macro param names were more descriptive, example : fw_def -> fw_namer or prefix -> gen But that's irrelevant here, so Reviewed-by: Alan Previn On Thu, 2022-09-08 at 17:16 -0700, Ceraolo Spurio, Daniele wrote: > The fw name is different and we need to record the fact tha

Re: [PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-09 Thread Ye, Tony
On 9/8/2022 5:16 PM, Daniele Ceraolo Spurio wrote: The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but t

[PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-08 Thread Daniele Ceraolo Spurio
The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but that's not a production stepping so we're not going to b