RE: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

Hi Laurent Pinchart, > Subject: Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node > pointers > > Hi Biju, > > Thank you for the patch. > > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > Having conditional around the of_node pointer

RE: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

Hi Helen Mae Koike Fornazier, > Subject: Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node > pointers > > Hello! > > Thanks for the patch. > > On Saturday, August 26, 2023 04:19 -03, Biju Das > wrote: > > > Having conditional around th

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

Hello! Thanks for the patch. On Saturday, August 26, 2023 04:19 -03, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. It would be nice to explain why those ifdev/if conditionals are not r

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

On Mon, Aug 28, 2023 at 02:29:21PM +0300, Laurent Pinchart wrote: > On Mon, Aug 28, 2023 at 02:17:02PM +0300, Andy Shevchenko wrote: > > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > > Having conditional around the of_node pointers turns out to make driver > > > code use ugly #ifdef

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

On Mon, Aug 28, 2023 at 02:17:02PM +0300, Andy Shevchenko wrote: > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > Having conditional around the of_node pointers turns out to make driver > > code use ugly #ifdef and #if blocks. So drop the conditionals. > > ... > > > -#ifdef CONFIG_

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

Hi Biju, Thank you for the patch. On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das >

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. ... > -#ifdef CONFIG_OF > /** @of_node: device node pointer to the bridge */ > struct de

[PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das --- v4: * New patch --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- include/drm/drm_bridg