Re: [PATCH v4 2/4] leds: Add managed API to get a LED from a device driver

2019-07-31 Thread Tomi Valkeinen
On 17/07/2019 17:15, Jean-Jacques Hiblot wrote: +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index) +{ + struct led_classdev *led; + struct led_classdev **dr; + Should you check here if dev->of_node == NULL?

[PATCH v4 2/4] leds: Add managed API to get a LED from a device driver

2019-07-17 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically released when the device is detached. Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek --- drivers/leds/led-class.c | 42 include/linux/leds.h | 2 ++ 2