Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-20 Thread Souptick Joarder
On Wed, Dec 19, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > On Wed, Dec 19, 2018 at 09:01:09AM +0530, Souptick Joarder wrote: > > On Tue, Dec 18, 2018 at 6:31 PM Russell King - ARM Linux > > wrote: > > > > > > On Tue, Dec 18, 2018 at 06:24:29PM +0530, Souptick Joarder wrote: > > > > On

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-20 Thread Souptick Joarder
On Wed, Dec 19, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Wed, Dec 19, 2018 at 05:16:09PM +0530, Souptick Joarder wrote: > > On Wed, Dec 19, 2018 at 3:02 PM Russell King - ARM Linux > > wrote: > > > > > > On Wed, Dec 19, 2018 at 09:01:09AM +0530, Souptick Joarder wrote: > > > > On

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-19 Thread Russell King - ARM Linux
On Wed, Dec 19, 2018 at 05:16:09PM +0530, Souptick Joarder wrote: > On Wed, Dec 19, 2018 at 3:02 PM Russell King - ARM Linux > wrote: > > > > On Wed, Dec 19, 2018 at 09:01:09AM +0530, Souptick Joarder wrote: > > > On Tue, Dec 18, 2018 at 6:31 PM Russell King - ARM Linux > > > wrote: > > > > > >

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-19 Thread Russell King - ARM Linux
On Wed, Dec 19, 2018 at 09:01:09AM +0530, Souptick Joarder wrote: > On Tue, Dec 18, 2018 at 6:31 PM Russell King - ARM Linux > wrote: > > > > On Tue, Dec 18, 2018 at 06:24:29PM +0530, Souptick Joarder wrote: > > > On Tue, Dec 18, 2018 at 6:03 PM Russell King - ARM Linux > > > wrote: > > > > > >

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-19 Thread Souptick Joarder
On Tue, Dec 18, 2018 at 6:31 PM Russell King - ARM Linux wrote: > > On Tue, Dec 18, 2018 at 06:24:29PM +0530, Souptick Joarder wrote: > > On Tue, Dec 18, 2018 at 6:03 PM Russell King - ARM Linux > > wrote: > > > > > > On Tue, Dec 18, 2018 at 05:36:04PM +0530, Souptick Joarder wrote: > > > > On

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-19 Thread Souptick Joarder
On Tue, Dec 18, 2018 at 6:03 PM Russell King - ARM Linux wrote: > > On Tue, Dec 18, 2018 at 05:36:04PM +0530, Souptick Joarder wrote: > > On Tue, Dec 18, 2018 at 3:27 PM Russell King - ARM Linux > > wrote: > > > This looks like a change in behaviour. > > > > > > If user_count is zero, and offset

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-19 Thread Souptick Joarder
On Tue, Dec 18, 2018 at 3:27 PM Russell King - ARM Linux wrote: > > On Tue, Dec 18, 2018 at 01:53:34AM +0530, Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > > memory to user vma. > > > > Signed-off-by: Souptick Joarder > > Tested-by: Heiko Stuebner > >

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 06:24:29PM +0530, Souptick Joarder wrote: > On Tue, Dec 18, 2018 at 6:03 PM Russell King - ARM Linux > wrote: > > > > On Tue, Dec 18, 2018 at 05:36:04PM +0530, Souptick Joarder wrote: > > > On Tue, Dec 18, 2018 at 3:27 PM Russell King - ARM Linux > > > wrote: > > > > This

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 05:36:04PM +0530, Souptick Joarder wrote: > On Tue, Dec 18, 2018 at 3:27 PM Russell King - ARM Linux > wrote: > > This looks like a change in behaviour. > > > > If user_count is zero, and offset is zero, then we pass into > > vm_insert_range() a page_count of zero, and

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 01:53:34AM +0530, Souptick Joarder wrote: > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder > Tested-by: Heiko Stuebner > Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 19

[PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git