Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Nicolas Boichat
On Wed, Feb 12, 2020 at 4:09 AM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat > > wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Rob Herring
On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat > > wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Rob Herring
+Saravana On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > When there is a single power domain per device, the core will > ensure the power domain is switched on (so it is technically > equivalent to having not power domain specified at all). > > However, when there are multiple

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Steven Price
On 07/02/2020 05:26, Nicolas Boichat wrote: > When there is a single power domain per device, the core will > ensure the power domain is switched on (so it is technically > equivalent to having not power domain specified at all). > > However, when there are multiple domains, as in MT8183 Bifrost

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Ulf Hansson
On Sun, 9 Feb 2020 at 13:50, Nicolas Boichat wrote: > > On Fri, Feb 7, 2020 at 10:26 PM Ulf Hansson wrote: > > > > On Fri, 7 Feb 2020 at 06:27, Nicolas Boichat wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power domain is switched on (so it is

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Alyssa Rosenzweig
> + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > + if (!pfdev->pm_domain_devs[i]) > + break; I'm not totally familiar with this code, but should this be a break or just a continue? signature.asc Description: PGP signature

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-10 Thread Ulf Hansson
On Fri, 7 Feb 2020 at 06:27, Nicolas Boichat wrote: > > When there is a single power domain per device, the core will > ensure the power domain is switched on (so it is technically > equivalent to having not power domain specified at all). > > However, when there are multiple domains, as in

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-09 Thread Nicolas Boichat
On Fri, Feb 7, 2020 at 10:26 PM Ulf Hansson wrote: > > On Fri, 7 Feb 2020 at 06:27, Nicolas Boichat wrote: > > > > When there is a single power domain per device, the core will > > ensure the power domain is switched on (so it is technically > > equivalent to having not power domain specified at

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-09 Thread Nicolas Boichat
On Fri, Feb 7, 2020 at 9:52 PM Alyssa Rosenzweig wrote: > > > + for (i = 0; i < ARRAY_SIZE(pfdev->pm_domain_devs); i++) { > > + if (!pfdev->pm_domain_devs[i]) > > + break; (next time, please provide a tiny bit more context when quoting, I had to look up to see

[PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-06 Thread Nicolas Boichat
When there is a single power domain per device, the core will ensure the power domain is switched on (so it is technically equivalent to having not power domain specified at all). However, when there are multiple domains, as in MT8183 Bifrost GPU, we need to handle them in driver code.