Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-03-08 Thread Nicolas Boichat
Looping back on this, after digging a bit deeper... On Fri, Feb 14, 2020 at 9:38 AM Nick Fan (范哲維) wrote: > [snip] > > > Another thing that I'm not implementing is the dance that Mediatek > > > does in their kbase driver when changing the clock (described in > > > patch > > > 2/7): > > > "" > >

RE: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-14 Thread 范哲維
___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-13 Thread Nicolas Boichat
On Thu, Feb 13, 2020 at 3:57 PM Nicolas Boichat wrote: > > > [snip] > > > But then there's a slight problem: panfrost_devfreq uses a bunch of > > > clk_get_rate calls, and the clock PLLs (at least on MTK platform) are > > > never fully precise, so we get back 29955 for 300 Mhz and > > >

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-13 Thread Viresh Kumar
On Wed, Feb 12, 2020 at 2:19 PM Nicolas Boichat wrote: > > +Viresh Kumar +Stephen Boyd for clock advice. You missed adding us in the cc list of the email, fixed that now :) ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Nicolas Boichat
+Weiyi Lu +Nick Fan @MTK who may have more ideas. On Thu, Feb 13, 2020 at 2:14 AM Rob Herring wrote: > > On Wed, Feb 12, 2020 at 2:49 AM Nicolas Boichat wrote: > > > > +Viresh Kumar +Stephen Boyd for clock advice. > > > > On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat > > wrote: > > > > > >

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Rob Herring
On Wed, Feb 12, 2020 at 2:49 AM Nicolas Boichat wrote: > > +Viresh Kumar +Stephen Boyd for clock advice. > > On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat wrote: > > > > The Bifrost GPU on MT8183 uses 2 regulators (core and SRAM) for > > devfreq, and provides OPP table with 2 sets of voltages.

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Nicolas Boichat
+Viresh Kumar +Stephen Boyd for clock advice. On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat wrote: > > The Bifrost GPU on MT8183 uses 2 regulators (core and SRAM) for > devfreq, and provides OPP table with 2 sets of voltages. > > TODO: This is incomplete as we'll need add support for setting >

[PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-06 Thread Nicolas Boichat
The Bifrost GPU on MT8183 uses 2 regulators (core and SRAM) for devfreq, and provides OPP table with 2 sets of voltages. TODO: This is incomplete as we'll need add support for setting a pair of voltages as well. Signed-off-by: Nicolas Boichat --- drivers/gpu/drm/panfrost/panfrost_devfreq.c |