Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-12 Thread Kuogee Hsieh
On 5/11/2022 6:03 PM, Dmitry Baryshkov wrote: On Thu, 12 May 2022 at 04:01, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-11 17:41:50) On 12/05/2022 03:02, Kuogee Hsieh wrote: diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index af7a80c..f3e333e

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-12 Thread Kuogee Hsieh
On 5/11/2022 6:03 PM, Dmitry Baryshkov wrote: On Thu, 12 May 2022 at 04:01, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-11 17:41:50) On 12/05/2022 03:02, Kuogee Hsieh wrote: diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index af7a80c..f3e333e

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-11 Thread Dmitry Baryshkov
On Thu, 12 May 2022 at 04:01, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-05-11 17:41:50) > > On 12/05/2022 03:02, Kuogee Hsieh wrote: > > > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > > > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > > > index af7a80c..f3e333e 100644 > > > ---

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-05-11 17:41:50) > On 12/05/2022 03:02, Kuogee Hsieh wrote: > > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > > index af7a80c..f3e333e 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > > +++

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-11 Thread Dmitry Baryshkov
On 12/05/2022 03:02, Kuogee Hsieh wrote: dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts after software reset of controller. At

[PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-11 Thread Kuogee Hsieh
dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts after software reset of controller. At current implementation,