Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Russell King - ARM Linux writes: > On Tue, Apr 11, 2017 at 02:00:21PM -0700, Eric Anholt wrote: >> Russell King - ARM Linux writes: >> >> > On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: >> >> Russell King - ARM Linux

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Wed, Apr 12, 2017 at 09:40:38AM +0200, Linus Walleij wrote: > On Wed, Apr 12, 2017 at 12:13 AM, Eric Anholt wrote: > > Oh, one last thing I think we need to figure out: I'm using TIM2_CLKSEL, > > which seems to be necessary on this platform. My understanding is that > > this

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Tue, Apr 11, 2017 at 02:00:21PM -0700, Eric Anholt wrote: > Russell King - ARM Linux writes: > > > On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: > >> Russell King - ARM Linux writes: > >> > >> > On Mon, Apr 10, 2017 at 06:18:01PM

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On 04/12, Neil Armstrong wrote: > On 04/12/2017 09:40 AM, Linus Walleij wrote: > > On Wed, Apr 12, 2017 at 12:13 AM, Eric Anholt wrote: > > > >> Oh, one last thing I think we need to figure out: I'm using TIM2_CLKSEL, > >> which seems to be necessary on this platform. My

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Wed, Apr 12, 2017 at 12:13 AM, Eric Anholt wrote: > Oh, one last thing I think we need to figure out: I'm using TIM2_CLKSEL, > which seems to be necessary on this platform. My understanding is that > this means that the pixel clock is divided from clcdclk instead of >

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: > Russell King - ARM Linux writes: > > > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: > >> v5: Move register definitions inside the driver directory, fix build > >> in COMPILE_TEST and !AMBA

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: > v5: Move register definitions inside the driver directory, fix build > in COMPILE_TEST and !AMBA mode. Why is it necessary to move the register definitions there, when they're already available in linux/amba/clcd.h and are

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Linus Walleij writes: > On Tue, Apr 11, 2017 at 3:18 AM, Eric Anholt wrote: > >> From: Tom Cooksey > > Well that can be debated at this point. I think it should have > your Author: tag and just Tom in the Signed-off-by, then

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Russell King - ARM Linux writes: > On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: >> Russell King - ARM Linux writes: >> >> > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: >> >> v5: Move register definitions inside the

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Linus Walleij writes: > On Tue, Apr 11, 2017 at 3:18 AM, Eric Anholt wrote: > >> From: Tom Cooksey > > Well that can be debated at this point. I think it should have > your Author: tag and just Tom in the Signed-off-by, then

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

Russell King - ARM Linux writes: > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: >> v5: Move register definitions inside the driver directory, fix build >> in COMPILE_TEST and !AMBA mode. > > Why is it necessary to move the register definitions there,

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Tue, Apr 11, 2017 at 11:17 AM, Linus Walleij wrote: >> +++ b/drivers/gpu/drm/pl111/Kconfig >> @@ -0,0 +1,12 @@ >> +config DRM_PL111 >> + tristate "DRM Support for PL111 CLCD Controller" >> + depends on DRM >> + depends on ARM || ARM64 || COMPILE_TEST

Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

On Tue, Apr 11, 2017 at 3:18 AM, Eric Anholt wrote: > From: Tom Cooksey Well that can be debated at this point. I think it should have your Author: tag and just Tom in the Signed-off-by, then mention the history in the commit message. > This is a

[PATCH v5] drm/pl111: Initial drm/kms driver for pl111

From: Tom Cooksey This is a modesetting driver for the pl111 CLCD display controller found on various ARM platforms such as the Versatile Express. The driver has only been tested on the bcm911360_entphn platform so far, with PRIME-based buffer sharing between vc4 and clcd.