Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-10 Thread Michel Dänzer
On 8/9/23 21:15, Marek Olšák wrote: > On Wed, Aug 9, 2023 at 3:35 AM Michel Dänzer > wrote: >> On 8/8/23 19:03, Marek Olšák wrote: >>> It's the same situation as SIGSEGV. A process can catch the signal, >>> but if it doesn't, it gets killed. GL and Vulkan APIs give you a way >>> to catch the GPU

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-09 Thread Marek Olšák
On Wed, Aug 9, 2023 at 3:35 AM Michel Dänzer wrote: > > On 8/8/23 19:03, Marek Olšák wrote: > > It's the same situation as SIGSEGV. A process can catch the signal, > > but if it doesn't, it gets killed. GL and Vulkan APIs give you a way > > to catch the GPU error and prevent the process

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-09 Thread Michel Dänzer
On 8/8/23 19:03, Marek Olšák wrote: > It's the same situation as SIGSEGV. A process can catch the signal, > but if it doesn't, it gets killed. GL and Vulkan APIs give you a way > to catch the GPU error and prevent the process termination. If you > don't use the API, you'll get undefined behavior,

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-08 Thread Marek Olšák
It's the same situation as SIGSEGV. A process can catch the signal, but if it doesn't, it gets killed. GL and Vulkan APIs give you a way to catch the GPU error and prevent the process termination. If you don't use the API, you'll get undefined behavior, which means anything can happen, including

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-08 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:03 PM Daniel Vetter wrote: > > On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-04 Thread Daniel Vetter
On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-08-02 Thread Michel Dänzer
On 8/2/23 09:38, Marek Olšák wrote: > > The precedent from the CPU land is pretty strong here. There is > SIGSEGV for invalid CPU memory access and SIGILL for invalid CPU > instructions, yet we do nothing for invalid GPU memory access and > invalid GPU instructions. Sending a terminating signal

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-08-02 Thread Marek Olšák
A screen that doesn't update isn't usable. Killing the window system and returning to the login screen is one option. Killing the window system manually from a terminal or over ssh and then returning to the login screen is another option, but 99% of users either hard-reset the machine or do

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-26 Thread Michel Dänzer
On 7/25/23 15:02, André Almeida wrote: > Em 25/07/2023 05:03, Michel Dänzer escreveu: >> On 7/25/23 04:55, André Almeida wrote: >>> Hi everyone, >>> >>> It's not clear what we should do about non-robust OpenGL apps after GPU >>> resets, so I'll try to summarize the topic, show some options and my

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-26 Thread Timur Kristóf
On Tue, 2023-07-25 at 19:00 +0200, Michel Dänzer wrote: > On 7/25/23 17:05, Marek Olšák wrote: > > On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer > > wrote: > > > On 7/25/23 04:55, André Almeida wrote: > > > > Hi everyone, > > > > > > > > It's not clear what we should do about non-robust OpenGL

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-25 Thread Michel Dänzer
On 7/25/23 17:05, Marek Olšák wrote: > On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer > wrote: >> On 7/25/23 04:55, André Almeida wrote: >>> Hi everyone, >>> >>> It's not clear what we should do about non-robust OpenGL apps after GPU >>> resets, so I'll try to summarize the topic, show some

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-25 Thread Marek Olšák
On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer wrote: > > On 7/25/23 04:55, André Almeida wrote: > > Hi everyone, > > > > It's not clear what we should do about non-robust OpenGL apps after GPU > > resets, so I'll try to summarize the topic, show some options and my > > proposal to move forward

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-25 Thread André Almeida
Hi Michel, Em 25/07/2023 05:03, Michel Dänzer escreveu: On 7/25/23 04:55, André Almeida wrote: Hi everyone, It's not clear what we should do about non-robust OpenGL apps after GPU resets, so I'll try to summarize the topic, show some options and my proposal to move forward on that. Em

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-25 Thread Michel Dänzer
On 7/25/23 04:55, André Almeida wrote: > Hi everyone, > > It's not clear what we should do about non-robust OpenGL apps after GPU > resets, so I'll try to summarize the topic, show some options and my proposal > to move forward on that. > > Em 27/06/2023 10:23, André Almeida escreveu: >>

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-25 Thread Simon Ser
On Tuesday, July 25th, 2023 at 04:55, André Almeida wrote: > It's not clear what we should do about non-robust OpenGL apps after GPU > resets, so I'll try to summarize the topic, show some options and my > proposal to move forward on that. > > Em 27/06/2023 10:23, André Almeida escreveu: > >

Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-24 Thread André Almeida
Hi everyone, It's not clear what we should do about non-robust OpenGL apps after GPU resets, so I'll try to summarize the topic, show some options and my proposal to move forward on that. Em 27/06/2023 10:23, André Almeida escreveu: +Robustness +-- + +The only way to try to keep an

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-05 Thread Marek Olšák
On Wed, Jul 5, 2023 at 3:32 AM Michel Dänzer wrote: > > On 7/5/23 08:30, Marek Olšák wrote: > > On Tue, Jul 4, 2023, 03:55 Michel Dänzer wrote: > > On 7/4/23 04:34, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > > wrote: > > > On 6/30/23 22:32, Marek Olšák

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-05 Thread Michel Dänzer
On 7/5/23 08:30, Marek Olšák wrote: > On Tue, Jul 4, 2023, 03:55 Michel Dänzer wrote: > On 7/4/23 04:34, Marek Olšák wrote: > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > >     On 6/30/23 22:32, Marek Olšák wrote: > >     > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-05 Thread Marek Olšák
On Tue, Jul 4, 2023, 03:55 Michel Dänzer wrote: > On 7/4/23 04:34, Marek Olšák wrote: > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > > On 6/30/23 22:32, Marek Olšák wrote: > > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer < >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Michel Dänzer
On 7/4/23 04:34, Marek Olšák wrote: > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > On 6/30/23 22:32, Marek Olšák wrote: > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > mailto:michel.daen...@mailbox.org> >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Pekka Paalanen
On Mon, 3 Jul 2023 12:00:22 -0300 André Almeida wrote: > Em 03/07/2023 05:49, Pekka Paalanen escreveu: > > If an application freezes, that's "no problem"; the end user can just > > continue using everything else. Alt-tab away etc. if the app was > > fullscreen. I do that already with games on

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Randy Dunlap
On 7/3/23 19:44, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 22:38 Randy Dunlap > wrote: > > > > On 7/3/23 19:34, Marek Olšák wrote: > > > > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Marek Olšák
On Mon, Jul 3, 2023, 22:38 Randy Dunlap wrote: > > > On 7/3/23 19:34, Marek Olšák wrote: > > > > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > > > > Marek, > Please stop sending html emails to the mailing lists. > The mailing list software drops

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Randy Dunlap
On 7/3/23 19:34, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > Marek, Please stop sending html emails to the mailing lists. The mailing list software drops them. Please set your email interface to use plain text mode

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Marek Olšák
On Mon, Jul 3, 2023, 03:12 Michel Dänzer wrote: > On 6/30/23 22:32, Marek Olšák wrote: > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer < > michel.daen...@mailbox.org > wrote: > >> On 6/30/23 16:59, Alex Deucher wrote: > >>> On Fri, Jun 30, 2023 at 10:49 AM

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread André Almeida
Em 03/07/2023 05:49, Pekka Paalanen escreveu: On Mon, 3 Jul 2023 09:12:29 +0200 Michel Dänzer wrote: On 6/30/23 22:32, Marek Olšák wrote: On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer mailto:michel.daen...@mailbox.org>> wrote: On 6/30/23 16:59, Alex Deucher wrote: On Fri, Jun 30, 2023

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Pekka Paalanen
On Mon, 3 Jul 2023 09:12:29 +0200 Michel Dänzer wrote: > On 6/30/23 22:32, Marek Olšák wrote: > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > > wrote: > >> On 6/30/23 16:59, Alex Deucher wrote: > >>> On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-03 Thread Michel Dänzer
On 6/30/23 22:32, Marek Olšák wrote: > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > wrote: >> On 6/30/23 16:59, Alex Deucher wrote: >>> On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick >>> mailto:sebastian.w...@redhat.com>> wrote: On Tue, Jun 27, 2023 at

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Marek Olšák
That's a terrible idea. Ignoring API calls would be identical to a freeze. You might as well disable GPU recovery because the result would be the same. There are 2 scenarios: - robust contexts: report the GPU reset status and skip API calls; let the app recreate the context to recover -

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 4:59 PM Alex Deucher wrote: > > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: > > > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida > > wrote: > > > > > > Create a section that specifies how to deal with DRM device resets for > > > kernel and userspace

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Michel Dänzer
On 6/30/23 16:59, Alex Deucher wrote: > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: >> On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: >>> >>> +Robustness >>> +-- >>> + >>> +The only way to try to keep an application working after a reset is if it >>> +complies with the

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Alex Deucher
On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick wrote: > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida > >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-29 Thread André Almeida
Em 27/06/2023 18:17, André Almeida escreveu: Em 27/06/2023 14:47, Christian König escreveu: Am 27.06.23 um 15:23 schrieb André Almeida: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Marek Olšák
On Tue, Jun 27, 2023 at 5:31 PM André Almeida wrote: > Hi Marek, > > Em 27/06/2023 15:57, Marek Olšák escreveu: > > On Tue, Jun 27, 2023, 09:23 André Almeida > > wrote: > > > > +User Mode Driver > > + > > + > > +The UMD should check

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread André Almeida
Hi Marek, Em 27/06/2023 15:57, Marek Olšák escreveu: On Tue, Jun 27, 2023, 09:23 André Almeida > wrote: +User Mode Driver + + +The UMD should check before submitting new commands to the KMD if the device has +been reset,

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread André Almeida
Em 27/06/2023 14:47, Christian König escreveu: Am 27.06.23 um 15:23 schrieb André Almeida: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida --- v4:

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Marek Olšák
On Tue, Jun 27, 2023, 09:23 André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Christian König
Am 27.06.23 um 15:23 schrieb André Almeida: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida --- v4: https://lore.kernel.org/lkml/20230626183347.55118-1-andrealm...@igalia.com/ Changes:

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Randy Dunlap
Hi André, I have just a few more below: On 6/27/23 06:23, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

[PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread André Almeida
Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida --- v4: https://lore.kernel.org/lkml/20230626183347.55118-1-andrealm...@igalia.com/ Changes: - Grammar fixes (Randy)