Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-05-07 Thread Andrey Grodzovsky
On 2021-05-07 12:29 p.m., Daniel Vetter wrote: On Fri, Apr 30, 2021 at 12:10:57PM -0400, Andrey Grodzovsky wrote: On 2021-04-30 2:47 a.m., Christian König wrote: Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-05-07 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 12:10:57PM -0400, Andrey Grodzovsky wrote: > > > On 2021-04-30 2:47 a.m., Christian König wrote: > > > > > > Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: > > > > > > > > > On 2021-04-29 3:18 a.m., Christian König wrote: > > > > I need to take another look at this

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-05-05 Thread Andrey Grodzovsky
Ping Andrey On 2021-04-30 12:10 p.m., Andrey Grodzovsky wrote: On 2021-04-30 2:47 a.m., Christian König wrote: Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-30 Thread Andrey Grodzovsky
On 2021-04-30 2:47 a.m., Christian König wrote: Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts,

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-30 Thread Christian König
Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts, something like: 1. Adding general infrastructure. 2.

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-29 Thread Andrey Grodzovsky
On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts, something like: 1. Adding general infrastructure. 2. Making sure all memory is unpolated. 3. Job and

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-29 Thread Christian König
I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts, something like: 1. Adding general infrastructure. 2. Making sure all memory is unpolated. 3. Job and fence handling Christian. Am 28.04.21 um 17:11

[PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-28 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run