Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-17 Thread Adrian Ratiu
On Thu, 16 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, [snip] >> >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, >> >hw_version); + dsi->hw_version &= VERSION; + if >> (!dsi->hw_version) +

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-16 Thread Enric Balletbo Serra
Hi Adrian, [snip] > >> > >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi > >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, > >> >hw_version); + dsi->hw_version &= VERSION; + > >> if (!dsi->hw_version) + dev_err(dsi->dev, "Failed > >> to read DSI hw

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-16 Thread Adrian Ratiu
On Wed, 15 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, Some few comments/nits below, Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: In order to support multiple versions of the Synopsis MIPI DSI host controller, which have different register layouts but almost

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-16 Thread Adrian Ratiu
On Wed, 15 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, Some few comments/nits below, Hi Enric, Thank you for your review, all your suggested changes will be part of v7. I have only one minor comment below. Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: In

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-15 Thread Enric Balletbo Serra
Hi Adrian, Some few comments/nits below, Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > In order to support multiple versions of the Synopsis MIPI DSI host > controller, which have different register layouts but almost identical > HW protocols, we add a regmap

[PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-14 Thread Adrian Ratiu
In order to support multiple versions of the Synopsis MIPI DSI host controller, which have different register layouts but almost identical HW protocols, we add a regmap infrastructure which can abstract away register accesses for platform drivers using the bridge. The controller HW revision is