Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-09-06 Thread Doug Anderson
Hi, On Thu, Aug 31, 2023 at 1:10 AM Biju Das wrote: > > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das > Reviewed-by: Douglas Anderson > --- >

Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. ... > anx78xx->bridge.of_node = client->dev.of_node; > panel_bridge->bridge.of_node =

Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das >

[PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Biju Das
Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das Reviewed-by: Douglas Anderson --- v5->v6: * Added Rb tag from Douglas Anderson. * Dropped conditionals