Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-21 Thread Maxime Ripard
Hi, On Wed, Oct 20, 2021 at 06:09:32PM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年9月28日周二 下午5:28写道: > > > > > +static int sprd_dsi_find_panel(struct sprd_dsi *dsi) > > > > > +{ > > > > > + struct device *dev = dsi->host.dev; > > > > > + struct device_node *child, *lcds_node; > > > >

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-20 Thread Kevin Tang
Maxime Ripard 于2021年9月28日周二 下午5:28写道: > > On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > > + struct drm_display_mode *mode, > > >

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-06 Thread Kevin Tang
Sam, Thanks for your response. Sam Ravnborg 于2021年9月27日周一 上午12:33写道: > > Hi Kevin, > > > > > + reg->_0b.bits.out_sel = pll->out_sel; > > > > + reg->_0b.bits.kint_l = pll->kint & 0xf; > > > > + reg->_0e.bits.pll_pu_byp = 0; > > > > + reg->_0e.bits.pll_pu = 0; > > > > +

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-06 Thread Kevin Tang
Maxime Ripard 于2021年9月28日周二 下午5:28写道: > > On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > > + struct drm_display_mode *mode, > > >

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-09-28 Thread Maxime Ripard
On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > + struct drm_display_mode *mode, > > > + struct

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-09-26 Thread Sam Ravnborg
Hi Kevin, > > > + reg->_0b.bits.out_sel = pll->out_sel; > > > + reg->_0b.bits.kint_l = pll->kint & 0xf; > > > + reg->_0e.bits.pll_pu_byp = 0; > > > + reg->_0e.bits.pll_pu = 0; > > > + reg->_0e.bits.stopstate_sel = 1; > > > + reg->_0f.bits.det_delay = pll->det_delay; > > >

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-09-26 Thread Kevin Tang
Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > On Fri, Aug 13, 2021 at 10:53:02PM +0800, Kevin Tang wrote: > > Adds dsi host controller support for the Unisoc's display subsystem. > > Adds dsi phy support for the Unisoc's display subsystem. > > Only MIPI DSI Displays supported, DP/TV/HMDI will be

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-09-17 Thread Maxime Ripard
On Fri, Aug 13, 2021 at 10:53:02PM +0800, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove dphy

[PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-08-13 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. v2: - Use