Re: [PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-14 Thread Andrey Grodzovsky
Makes sense - will update. Andrey On 2021-05-14 12:25 p.m., Felix Kuehling wrote: Maybe this patch needs a better explanation how the GART and IH changes relate to IOMMU or what's the problem this is meant to fix. Just looking at the patch I don't see the connection. Looks like just a bunch of

Re: [PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-14 Thread Felix Kuehling
Maybe this patch needs a better explanation how the GART and IH changes relate to IOMMU or what's the problem this is meant to fix. Just looking at the patch I don't see the connection. Looks like just a bunch of refactoring to me. Regards,   Felix Am 2021-05-14 um 10:41 a.m. schrieb Andrey

Re: [PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-14 Thread Andrey Grodzovsky
Ping Andrey On 2021-05-12 10:26 a.m., Andrey Grodzovsky wrote: Handle all DMA IOMMU gropup related dependencies before the group is removed. v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate v6: Drop the BO unamp list v7: Drop amdgpu_gart_fini In amdgpu_ih_ring_fini do

[PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-12 Thread Andrey Grodzovsky
Handle all DMA IOMMU gropup related dependencies before the group is removed. v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate v6: Drop the BO unamp list v7: Drop amdgpu_gart_fini In amdgpu_ih_ring_fini do uncinditional check (!ih->ring) to avoid freeing uniniitalized