Re: [PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-20 Thread Alistair Popple
On Friday, 21 May 2021 6:24:27 AM AEST Liam Howlett wrote: [...] > > > > diff --git a/mm/rmap.c b/mm/rmap.c > > > > index 977e70803ed8..f09d522725b9 100644 > > > > --- a/mm/rmap.c > > > > +++ b/mm/rmap.c > > > > @@ -1405,10 +1405,6 @@ static bool try_to_unmap_one(struct page *page, > > > >

Re: [PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-20 Thread Liam Howlett
* Alistair Popple [210519 08:38]: > On Wednesday, 19 May 2021 6:04:51 AM AEST Liam Howlett wrote: > > External email: Use caution opening links or attachments > > > > * Alistair Popple [210407 04:43]: > > > The behaviour of try_to_unmap_one() is difficult to follow because it > > > performs

Re: [PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 6:04:51 AM AEST Liam Howlett wrote: > External email: Use caution opening links or attachments > > * Alistair Popple [210407 04:43]: > > The behaviour of try_to_unmap_one() is difficult to follow because it > > performs different operations based on a fairly large set

Re: [PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-18 Thread Liam Howlett
* Alistair Popple [210407 04:43]: > The behaviour of try_to_unmap_one() is difficult to follow because it > performs different operations based on a fairly large set of flags used > in different combinations. > > TTU_MUNLOCK is one such flag. However it is exclusively used by > try_to_munlock()

[PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-04-07 Thread Alistair Popple
The behaviour of try_to_unmap_one() is difficult to follow because it performs different operations based on a fairly large set of flags used in different combinations. TTU_MUNLOCK is one such flag. However it is exclusively used by try_to_munlock() which specifies no other flags. Therefore