Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-29 Thread Tomi Valkeinen
Hi, On 17/04/2019 10:32, Andrzej Hajda wrote: > On 15.04.2019 12:59, Tomi Valkeinen wrote: >> On 15/04/2019 13:42, Andrzej Hajda wrote: >> >>> Ok we have here 4 combinations: >>> >>> 1. noHPD + eDP. >>> >>> 2. noHPD + DP. >>> >>> 3. HPD + eDP. >>> >>> 4. HPD + DP. >>> >>> >>> Which ones do you

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-17 Thread Andrzej Hajda
On 15.04.2019 12:59, Tomi Valkeinen wrote: > On 15/04/2019 13:42, Andrzej Hajda wrote: > >> Ok we have here 4 combinations: >> >> 1. noHPD + eDP. >> >> 2. noHPD + DP. >> >> 3. HPD + eDP. >> >> 4. HPD + DP. >> >> >> Which ones do you want to support, disallow. It is not clear to me. > They all

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-15 Thread Tomi Valkeinen
On 15/04/2019 13:42, Andrzej Hajda wrote: > Ok we have here 4 combinations: > > 1. noHPD + eDP. > > 2. noHPD + DP. > > 3. HPD + eDP. > > 4. HPD + DP. > > > Which ones do you want to support, disallow. It is not clear to me. They all should work. If there is HPD, we use it to return

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-15 Thread Andrzej Hajda
On 26.03.2019 11:31, Tomi Valkeinen wrote: > Add support for interrupt and hotplug handling. Both are optional. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358767.c | 157 ++ > 1 file changed, 139 insertions(+), 18 deletions(-) > > diff --git

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-15 Thread Andrey Smirnov
On Fri, Apr 12, 2019 at 1:02 AM Tomi Valkeinen wrote: > > Hi Andrey, > > On 03/04/2019 14:34, Tomi Valkeinen wrote: > > On 02/04/2019 05:16, Andrey Smirnov wrote: > > > >> The early return above causes tc_get_display_props() to never be > >> called for eDP case, which in turn result in

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-12 Thread Tomi Valkeinen
Hi Andrey, On 03/04/2019 14:34, Tomi Valkeinen wrote: > On 02/04/2019 05:16, Andrey Smirnov wrote: > >> The early return above causes tc_get_display_props() to never be >> called for eDP case, which in turn result in tc_mode_valid() returning >> MODE_BAD for every mode it is given since it

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-03 Thread Tomi Valkeinen
On 02/04/2019 05:16, Andrey Smirnov wrote: > The early return above causes tc_get_display_props() to never be > called for eDP case, which in turn result in tc_mode_valid() returning > MODE_BAD for every mode it is given since it depends on tc->link.base > being initialized properly. I had to

Re: [PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-04-02 Thread Andrey Smirnov
On Tue, Mar 26, 2019 at 3:33 AM Tomi Valkeinen wrote: > > Add support for interrupt and hotplug handling. Both are optional. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358767.c | 157 ++ > 1 file changed, 139 insertions(+), 18 deletions(-) > >

[PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-03-26 Thread Tomi Valkeinen
Add support for interrupt and hotplug handling. Both are optional. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 157 ++ 1 file changed, 139 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c