* Tomi Valkeinen [191011 10:25]:
> On 10/10/2019 16:24, Tony Lindgren wrote:
>
> > Hmm so what register does this clock actually change?
> >
> > I'm seeing an increase of few tens of extra mW, which means at
> > least one day of standby time less for me :) It does not happen
> > always, maybe
On 10/10/2019 16:24, Tony Lindgren wrote:
Hmm so what register does this clock actually change?
I'm seeing an increase of few tens of extra mW, which means at
least one day of standby time less for me :) It does not happen
always, maybe half of the time.
I have no idea why this would affect
* Tomi Valkeinen [191010 06:48]:
> On 08/10/2019 17:21, Tony Lindgren wrote:
> > * Tomi Valkeinen [191008 14:17]:
> > > On 08/10/2019 17:13, Tony Lindgren wrote:
> > > > * Tomi Valkeinen [190930 10:38]:
> > > > > If use_mclk is false, mclk_mode is written to a register without
> > > > >
On 08/10/2019 17:21, Tony Lindgren wrote:
* Tomi Valkeinen [191008 14:17]:
On 08/10/2019 17:13, Tony Lindgren wrote:
* Tomi Valkeinen [190930 10:38]:
If use_mclk is false, mclk_mode is written to a register without
initialization. This doesn't cause any ill effects as the written value
is
* Tomi Valkeinen [191008 14:17]:
> On 08/10/2019 17:13, Tony Lindgren wrote:
> > * Tomi Valkeinen [190930 10:38]:
> > > If use_mclk is false, mclk_mode is written to a register without
> > > initialization. This doesn't cause any ill effects as the written value
> > > is not used when use_mclk
* Tomi Valkeinen [190930 10:38]:
> If use_mclk is false, mclk_mode is written to a register without
> initialization. This doesn't cause any ill effects as the written value
> is not used when use_mclk is false.
>
> To fix this, write use_mclk only when use_mclk is true.
Hey nice catch. Based
On 08/10/2019 17:13, Tony Lindgren wrote:
* Tomi Valkeinen [190930 10:38]:
If use_mclk is false, mclk_mode is written to a register without
initialization. This doesn't cause any ill effects as the written value
is not used when use_mclk is false.
To fix this, write use_mclk only when
Hi Tomi,
Thank you for the patch.
On Mon, Sep 30, 2019 at 01:38:40PM +0300, Tomi Valkeinen wrote:
> If use_mclk is false, mclk_mode is written to a register without
> initialization. This doesn't cause any ill effects as the written value
> is not used when use_mclk is false.
>
> To fix this,
If use_mclk is false, mclk_mode is written to a register without
initialization. This doesn't cause any ill effects as the written value
is not used when use_mclk is false.
To fix this, write use_mclk only when use_mclk is true.
Signed-off-by: Tomi Valkeinen
---
