RE: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2016-01-04 Thread Meng Yi
: Re: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug Hi, On 30 December 2015 at 07:37, Meng Yi wrote: > I have tested your patch, It seems good to me. > But I think state->fb check is still necessary, because fb is related to crtc > , and panel is related to connector,. Wh

Re: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2016-01-03 Thread Stefan Agner
On 2016-01-01 07:10, Daniel Stone wrote: > Hi, > > On 30 December 2015 at 07:37, Meng Yi wrote: >> I have tested your patch, It seems good to me. >> But I think state->fb check is still necessary, because fb is related to >> crtc , and panel is related to connector,. When fsl,panel is not

Re: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2016-01-01 Thread Daniel Stone
Hi, On 30 December 2015 at 07:37, Meng Yi wrote: > I have tested your patch, It seems good to me. > But I think state->fb check is still necessary, because fb is related to crtc > , and panel is related to connector,. When fsl,panel is not valid, it > indicate that connector is not available,

RE: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-30 Thread Meng Yi
­”复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug Hi Meng, The only situation I could observe that is when fsl,panel was not valid... However, I think with my patch "drm/fsl-dcu: Fix no fb check bug", this situation can be avoided completely: https://lkml.org/lkml/2015/11/18/950 Wi

[RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-28 Thread Daniel Stone
Hi Stefan, On Sunday, 27 December 2015, Stefan Agner wrote: > > However, I think with my patch "drm/fsl-dcu: Fix no fb check bug", this > situation can be avoided completely: > https://lkml.org/lkml/2015/11/18/950 > > With that patch applied, and a non-existing panel assigned, the DRM > driver

Re: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-26 Thread Stefan Agner
送: stefan at agner.ch; dri-devel at lists.freedesktop.org; Jianwei Wang > ; Yi Meng-B56799 ; > Wang Dongsheng-B40534 > 主题: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug > > From: Jianwei Wang > > For state->fb may be NULL in fsl_dcu_drm_plane_ato

[RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-24 Thread Daniel Stone
Hi, On 1 December 2015 at 08:15, Dongsheng Wang wrote: > From: Jianwei Wang > > For state->fb may be NULL in fsl_dcu_drm_plane_atomic_check function, > if so, return -EINVAL. No need check in fsl_dcu_drm_plane_atomic_update > anymore. > > Signed-off-by: Jianwei Wang > Signed-off-by: Yi Meng >

答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-24 Thread Meng Yi
Dongsheng-B40534 主题: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug From: Jianwei Wang <jianwei.wang@gmail.com> For state->fb may be NULL in fsl_dcu_drm_plane_atomic_check function, if so, return -EINVAL. No need check in fsl_dcu_drm_plane_atomic_update anymore. Signed-off-by: Jia

[RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2015-12-01 Thread Dongsheng Wang
From: Jianwei Wang For state->fb may be NULL in fsl_dcu_drm_plane_atomic_check function, if so, return -EINVAL. No need check in fsl_dcu_drm_plane_atomic_update anymore. Signed-off-by: Jianwei Wang Signed-off-by: Yi Meng Signed-off-by: Wang Dongsheng Tested-by: