Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-29 Thread Boris Brezillon
On Tue, 28 May 2019 16:01:15 +0200 Boris Brezillon wrote: > On Tue, 28 May 2019 15:53:48 +0200 > Boris Brezillon wrote: > > > Hi Steve, > > > > On Thu, 16 May 2019 17:21:39 +0100 > > Steven Price wrote: > > > > > > > >> +static void panfrost_perfcnt_setup(struct panfrost_device *pfdev) >

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-28 Thread Boris Brezillon
On Tue, 28 May 2019 15:53:48 +0200 Boris Brezillon wrote: > Hi Steve, > > On Thu, 16 May 2019 17:21:39 +0100 > Steven Price wrote: > > > > >> +static void panfrost_perfcnt_setup(struct panfrost_device *pfdev) > > >> +{ > > >> + u32 cfg; > > >> + > > >> + /* > > >> +*

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-28 Thread Boris Brezillon
Hi Steve, On Thu, 16 May 2019 17:21:39 +0100 Steven Price wrote: > >> +static void panfrost_perfcnt_setup(struct panfrost_device *pfdev) > >> +{ > >> + u32 cfg; > >> + > >> + /* > >> +* Always use address space 0 for now. > >> +* FIXME: this needs to be updated when

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-17 Thread Steven Price
On 14/05/2019 14:31, Rob Herring wrote: > On Tue, May 14, 2019 at 5:48 AM Boris Brezillon > wrote: >> >> Add a way to dump perf counters through debugfs. The implementation is >> kept simple and has a number of limitations: >> >> * it's not designed for multi-user usage as the counter values are

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-14 Thread Boris Brezillon
Hi Rob, On Tue, 14 May 2019 08:31:29 -0500 Rob Herring wrote: > > + > > +static void panfrost_perfcnt_setup(struct panfrost_device *pfdev) > > +{ > > + u32 cfg; > > + > > + /* > > +* Always use address space 0 for now. > > +* FIXME: this needs to be updated when we

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-14 Thread Rob Herring
On Tue, May 14, 2019 at 5:48 AM Boris Brezillon wrote: > > Add a way to dump perf counters through debugfs. The implementation is > kept simple and has a number of limitations: > > * it's not designed for multi-user usage as the counter values are > reset after each dump and there's no per-user

Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-14 Thread Emil Velikov
On Tue, 14 May 2019 at 11:48, Boris Brezillon wrote: > > Add a way to dump perf counters through debugfs. The implementation is > kept simple and has a number of limitations: > > * it's not designed for multi-user usage as the counter values are > reset after each dump and there's no per-user

[RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs

2019-05-14 Thread Boris Brezillon
Add a way to dump perf counters through debugfs. The implementation is kept simple and has a number of limitations: * it's not designed for multi-user usage as the counter values are reset after each dump and there's no per-user context * only accessible to root users * no counters