Re: [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+

2013-10-07 Thread Alex Deucher
On Mon, Oct 7, 2013 at 12:47 PM, Rafał Miłecki wrote: > 2013/10/7 Alex Deucher : >> On Sun, Oct 6, 2013 at 4:46 PM, Rafał Miłecki wrote: >>> Write to HDMI_VBI_PACKET_CONTROL was duplicated. >>> Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from >>> DCE2/3 code (copy & paste) an

Re: [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+

2013-10-07 Thread Rafał Miłecki
2013/10/7 Alex Deucher : > On Sun, Oct 6, 2013 at 4:46 PM, Rafał Miłecki wrote: >> Write to HDMI_VBI_PACKET_CONTROL was duplicated. >> Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from >> DCE2/3 code (copy & paste) and were never needed on DCE4+. >> >> See https://bugzilla.kern

Re: [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+

2013-10-07 Thread Alex Deucher
On Sun, Oct 6, 2013 at 4:46 PM, Rafał Miłecki wrote: > Write to HDMI_VBI_PACKET_CONTROL was duplicated. > Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from > DCE2/3 code (copy & paste) and were never needed on DCE4+. > > See https://bugzilla.kernel.org/show_bug.cgi?id=62591 for

[RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+

2013-10-06 Thread Rafał Miłecki
Write to HDMI_VBI_PACKET_CONTROL was duplicated. Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from DCE2/3 code (copy & paste) and were never needed on DCE4+. See https://bugzilla.kernel.org/show_bug.cgi?id=62591 for details. --- That patches weren't tested with the HW, please d