Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 10:32 AM Christian König wrote: > > > > Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > >> On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > >>> On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 9:21 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 5:39 PM Suren Baghdasaryan wrote: > > > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > > > > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > > > On Tue, Feb 9, 2021 at 12:03 PM

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > > > wrote: > > > > > > > > > > > > > > > > Am

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Christian König
Am 10.02.21 um 20:12 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 10:32 AM Christian König wrote: Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: On Tue, Feb

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Christian König
Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: On Tue, Feb 9, 2021 at 6:46 PM Christian König wrote: Am

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 5:39 PM Suren Baghdasaryan wrote: > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > > > > > On Tue, Feb 9, 2021 at 6:46

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > > wrote: > > > > > > > > > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > > > On Tue, Feb 9, 2021 at

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > wrote: > > > > > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > > wrote: > > >> Am 09.02.21 um 13:11 schrieb Christian

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 9:46 AM Christian König wrote: > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > wrote: > >> Am 09.02.21 um 13:11 schrieb Christian König: > >>> [SNIP] > >> +void drm_page_pool_add(struct drm_page_pool

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Suren Baghdasaryan
On Tue, Feb 9, 2021 at 4:57 AM Christian König wrote: > > Am 09.02.21 um 13:11 schrieb Christian König: > > [SNIP] > +void drm_page_pool_add(struct drm_page_pool *pool, struct page *page) > +{ > + spin_lock(>lock); > + list_add_tail(>lru, >items); > +

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Daniel Vetter
On Tue, Feb 9, 2021 at 6:46 PM Christian König wrote: > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > On Tue, Feb 9, 2021 at 4:57 AM Christian König > > wrote: > >> Am 09.02.21 um 13:11 schrieb Christian König: > >>> [SNIP] > >> +void drm_page_pool_add(struct drm_page_pool

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread John Stultz
On Tue, Feb 9, 2021 at 4:11 AM Christian König wrote: > > > > Am 05.02.21 um 21:46 schrieb John Stultz: > > On Fri, Feb 5, 2021 at 12:47 AM Christian König > > wrote: > >> Am 05.02.21 um 09:06 schrieb John Stultz: > >>> diff --git a/drivers/gpu/drm/page_pool.c b/drivers/gpu/drm/page_pool.c > >>>

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Christian König
Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: On Tue, Feb 9, 2021 at 4:57 AM Christian König wrote: Am 09.02.21 um 13:11 schrieb Christian König: [SNIP] +void drm_page_pool_add(struct drm_page_pool *pool, struct page *page) +{ + spin_lock(>lock); + list_add_tail(>lru, >items); +

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Christian König
Am 09.02.21 um 13:11 schrieb Christian König: [SNIP] +void drm_page_pool_add(struct drm_page_pool *pool, struct page *page) +{ + spin_lock(>lock); + list_add_tail(>lru, >items); + pool->count++; + atomic_long_add(1 << pool->order, _pages); + spin_unlock(>lock); + +

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-09 Thread Christian König
Am 05.02.21 um 21:46 schrieb John Stultz: On Fri, Feb 5, 2021 at 12:47 AM Christian König wrote: Am 05.02.21 um 09:06 schrieb John Stultz: diff --git a/drivers/gpu/drm/page_pool.c b/drivers/gpu/drm/page_pool.c new file mode 100644 index ..2139f86e6ca7 --- /dev/null +++

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-05 Thread Suren Baghdasaryan
On Fri, Feb 5, 2021 at 12:47 PM John Stultz wrote: > > On Fri, Feb 5, 2021 at 12:47 AM Christian König > wrote: > > Am 05.02.21 um 09:06 schrieb John Stultz: > > > diff --git a/drivers/gpu/drm/page_pool.c b/drivers/gpu/drm/page_pool.c > > > new file mode 100644 > > > index

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-05 Thread John Stultz
On Fri, Feb 5, 2021 at 12:47 AM Christian König wrote: > Am 05.02.21 um 09:06 schrieb John Stultz: > > diff --git a/drivers/gpu/drm/page_pool.c b/drivers/gpu/drm/page_pool.c > > new file mode 100644 > > index ..2139f86e6ca7 > > --- /dev/null > > +++ b/drivers/gpu/drm/page_pool.c > >

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-05 Thread Christian König
Am 05.02.21 um 09:06 schrieb John Stultz: This adds a shrinker controlled page pool, closely following the ttm_pool logic, which is abstracted out a bit so it can be used by other non-ttm drivers. Cc: Daniel Vetter Cc: Christian Koenig Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy

[RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-05 Thread John Stultz
This adds a shrinker controlled page pool, closely following the ttm_pool logic, which is abstracted out a bit so it can be used by other non-ttm drivers. Cc: Daniel Vetter Cc: Christian Koenig Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: