Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-24 Thread Heikki Krogerus
On Mon, May 22, 2023 at 02:53:48PM -0700, Bjorn Andersson wrote: > On Mon, May 22, 2023 at 03:51:01PM -0500, Bjorn Andersson wrote: > > On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > > >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-22 Thread Bjorn Andersson
On Mon, May 22, 2023 at 03:51:01PM -0500, Bjorn Andersson wrote: > On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > > Hi, > > > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > > The one thing that I still don't understand though is, if the typec_mux > > >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-22 Thread Bjorn Andersson
On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > Hi, > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > The one thing that I still don't understand though is, if the typec_mux > > is used by the typec controller to inform _the_ mux about the function > > to

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-07 Thread Imre Deak
On Tue, Dec 07, 2021 at 02:26:05PM +0200, Heikki Krogerus wrote: > +Hans and Imre > [...] > > Originally I wanted an API that we could use to pass all the details > that we have in the USB Type-C drivers (that would be the > configuration and status) to the GPU drivers, but Hans was against > that

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-07 Thread Bjorn Andersson
On Tue 07 Dec 08:56 PST 2021, Hans de Goede wrote: > Hi all, > > On 12/7/21 13:26, Heikki Krogerus wrote: > > +Hans and Imre > > > > On Mon, Dec 06, 2021 at 02:31:40PM -0800, Bjorn Andersson wrote: > >> On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > >>> On Wed, Oct 06, 2021 at

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-07 Thread Hans de Goede
Hi all, On 12/7/21 13:26, Heikki Krogerus wrote: > +Hans and Imre > > On Mon, Dec 06, 2021 at 02:31:40PM -0800, Bjorn Andersson wrote: >> On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: >>> On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: (CC+ Heikki) >> [..] On

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-07 Thread Heikki Krogerus
+Hans and Imre On Mon, Dec 06, 2021 at 02:31:40PM -0800, Bjorn Andersson wrote: > On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > > On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > > > (CC+ Heikki) > [..] > > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson > > > wrote: >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-06 Thread Bjorn Andersson
On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > > (CC+ Heikki) [..] > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: [..] > void drm_connector_oob_hotplug_event(struct fwnode_handle > *connector_fwnode); >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-08 Thread Heikki Krogerus
Hi, On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > The one thing that I still don't understand though is, if the typec_mux > is used by the typec controller to inform _the_ mux about the function > to be used, what's up with the complexity in typec_mux_match()? This is > what

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-07 Thread Bjorn Andersson
On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > Hi guys, > > On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > > (CC+ Heikki) > > > > Hi, > > > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-07 Thread Heikki Krogerus
Hi guys, On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > (CC+ Heikki) > > Hi, > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson > > wrote: > > > > > > > > For reference, this is how I thought one is

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-07 Thread Prashant Malani
(CC+ Heikki) Hi, On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > Hi, > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson > wrote: > > > > > > For reference, this is how I thought one is supposed to tie the Type-C > > > > controller to the display driver: > > > >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-06 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson wrote: > > > > For reference, this is how I thought one is supposed to tie the Type-C > > > controller to the display driver: > > > https://lore.kernel.org/all/20211005022451.2037405-1-bjorn.anders...@linaro.org/ > > > > OK, so I looked at that

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Bjorn Andersson
On Tue 05 Oct 16:09 PDT 2021, Doug Anderson wrote: > Hi, > > On Tue, Oct 5, 2021 at 10:33 AM Bjorn Andersson > wrote: > > > > On Tue 05 Oct 08:39 PDT 2021, Doug Anderson wrote: > > > > > Hi, > > > > > > On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson > > > wrote: > > > > > > > > On Mon 04 Oct

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 10:33 AM Bjorn Andersson wrote: > > On Tue 05 Oct 08:39 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson > > wrote: > > > > > > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > > > > > Hi, > > > > > > > > On Fri,

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Bjorn Andersson
On Tue 05 Oct 08:39 PDT 2021, Doug Anderson wrote: > Hi, > > On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson > wrote: > > > > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > > > Hi, > > > > > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > > > wrote: > > > > > > > > On Fri 27 Aug

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-05 Thread Doug Anderson
Hi, On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson wrote: > > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > > wrote: > > > > > > On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > > > > > > > Hi, > > > > > > > > On Mon,

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-04 Thread Bjorn Andersson
On Mon 04 Oct 20:50 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-04 18:11:11) > > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > > > Hi, > > > > > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > > > wrote: > > > > > > > > On Fri 27 Aug 13:52 PDT 2021, Doug

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-04 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-10-04 18:11:11) > On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > > wrote: > > > > > > On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > > > > > > > Hi, > > > > > > > > On Mon, Jul 26, 2021 at

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-04 Thread Bjorn Andersson
On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote: > Hi, > > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson > wrote: > > > > On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > > > > > Hi, > > > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > > wrote: > > > > > > > > +static int

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-04 Thread Doug Anderson
Hi, On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson wrote: > > On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > wrote: > > > > > > +static int dp_parser_find_panel(struct dp_parser *parser) > > > +{ > > > + struct

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-01 Thread Bjorn Andersson
On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote: > Hi, > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > wrote: > > > > +static int dp_parser_find_panel(struct dp_parser *parser) > > +{ > > + struct device_node *np = parser->pdev->dev.of_node; > > + int rc; > > + > > +

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-30 Thread Doug Anderson
Hi, On Sat, Aug 28, 2021 at 7:40 AM Bjorn Andersson wrote: > > On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > wrote: > > > > > > +static int dp_parser_find_panel(struct dp_parser *parser) > > > +{ > > > + struct

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-28 Thread Bjorn Andersson
On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote: > Hi, > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > wrote: > > > > +static int dp_parser_find_panel(struct dp_parser *parser) > > +{ > > + struct device_node *np = parser->pdev->dev.of_node; > > + int rc; > > + > > +

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-27 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, >drm_panel, NULL); Why port 2?

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Wed, Aug 25, 2021 at 6:31 PM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-07-26 16:13:51) > > eDP panels might need some power sequencing and backlight management, > > so make it possible to associate a drm_panel with a DP instance and > > prepare and enable the panel

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, >drm_panel, NULL); > + if

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-25 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-26 16:13:51) > eDP panels might need some power sequencing and backlight management, > so make it possible to associate a drm_panel with a DP instance and > prepare and enable the panel accordingly. > > Signed-off-by: Bjorn Andersson > --- > > This solves my

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-25 Thread Bjorn Andersson
On Thu 29 Jul 04:59 CDT 2021, Dmitry Baryshkov wrote: > On 27/07/2021 02:13, Bjorn Andersson wrote: > > eDP panels might need some power sequencing and backlight management, > > so make it possible to associate a drm_panel with a DP instance and > > prepare and enable the panel accordingly. > >

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-07-29 Thread Dmitry Baryshkov
On 27/07/2021 02:13, Bjorn Andersson wrote: eDP panels might need some power sequencing and backlight management, so make it possible to associate a drm_panel with a DP instance and prepare and enable the panel accordingly. Signed-off-by: Bjorn Andersson The idea looks good from my point of

[RFC] drm/msm/dp: Allow attaching a drm_panel

2021-07-26 Thread Bjorn Andersson
eDP panels might need some power sequencing and backlight management, so make it possible to associate a drm_panel with a DP instance and prepare and enable the panel accordingly. Signed-off-by: Bjorn Andersson --- This solves my immediate problem on my 8cx laptops, of indirectly controlling