Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-21 Thread Daniel Vetter
On Fri, May 21, 2021 at 09:43:59AM +0200, Christian König wrote: > Am 20.05.21 um 19:08 schrieb Daniel Vetter: > > [SNIP] > > > AH! So we are basically telling the fence backend that we have just > > > missed an event we waited for. > > > > > > So what we want to know is how long the frontend

Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-21 Thread Christian König
Am 20.05.21 um 19:08 schrieb Daniel Vetter: [SNIP] AH! So we are basically telling the fence backend that we have just missed an event we waited for. So what we want to know is how long the frontend wanted to wait instead of how long the backend took for rendering. tbh I'm not sure the

Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Daniel Vetter
On Thu, May 20, 2021 at 6:41 PM Christian König wrote: > > Am 20.05.21 um 18:34 schrieb Daniel Vetter: > > On Thu, May 20, 2021 at 06:01:39PM +0200, Christian König wrote: > >> Am 20.05.21 um 16:54 schrieb Rob Clark: > >>> On Thu, May 20, 2021 at 7:11 AM Christian König > >>> wrote: > >

Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Christian König
Am 20.05.21 um 18:34 schrieb Daniel Vetter: On Thu, May 20, 2021 at 06:01:39PM +0200, Christian König wrote: Am 20.05.21 um 16:54 schrieb Rob Clark: On Thu, May 20, 2021 at 7:11 AM Christian König wrote: Am 20.05.21 um 16:07 schrieb Rob Clark: On Wed, May 19, 2021 at 11:47 PM Christian

Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Daniel Vetter
On Thu, May 20, 2021 at 06:01:39PM +0200, Christian König wrote: > Am 20.05.21 um 16:54 schrieb Rob Clark: > > On Thu, May 20, 2021 at 7:11 AM Christian König > > wrote: > > > > > > > > > Am 20.05.21 um 16:07 schrieb Rob Clark: > > > > On Wed, May 19, 2021 at 11:47 PM Christian König > > > >

Re: [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Daniel Vetter
On Thu, May 20, 2021 at 4:03 PM Rob Clark wrote: > > On Wed, May 19, 2021 at 11:47 PM Christian König > wrote: > > > > Uff, that looks very hardware specific to me. > > Howso? I'm not sure I agree.. and even if it was not useful for some > hw, it should be useful for enough drivers (and harm no

Re: [Linaro-mm-sig] [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Christian König
Am 20.05.21 um 16:54 schrieb Rob Clark: On Thu, May 20, 2021 at 7:11 AM Christian König wrote: Am 20.05.21 um 16:07 schrieb Rob Clark: On Wed, May 19, 2021 at 11:47 PM Christian König wrote: Uff, that looks very hardware specific to me. Howso? I'm not sure I agree.. and even if it was

Re: [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Rob Clark
On Thu, May 20, 2021 at 7:11 AM Christian König wrote: > > > > Am 20.05.21 um 16:07 schrieb Rob Clark: > > On Wed, May 19, 2021 at 11:47 PM Christian König > > wrote: > >> Uff, that looks very hardware specific to me. > > Howso? I'm not sure I agree.. and even if it was not useful for some > >

Re: [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Christian König
Am 20.05.21 um 16:07 schrieb Rob Clark: On Wed, May 19, 2021 at 11:47 PM Christian König wrote: Uff, that looks very hardware specific to me. Howso? I'm not sure I agree.. and even if it was not useful for some hw, it should be useful for enough drivers (and harm no drivers), so I still

Re: [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Rob Clark
On Wed, May 19, 2021 at 11:47 PM Christian König wrote: > > Uff, that looks very hardware specific to me. Howso? I'm not sure I agree.. and even if it was not useful for some hw, it should be useful for enough drivers (and harm no drivers), so I still think it is a good idea The fallback plan

Re: [RFC 1/3] dma-fence: Add boost fence op

2021-05-20 Thread Christian König
Uff, that looks very hardware specific to me. As far as I can see you can also implement completely inside the backend by starting a timer on enable_signaling, don't you? Christian. Am 19.05.21 um 20:38 schrieb Rob Clark: From: Rob Clark Add a way to hint to the fence signaler that a

[RFC 1/3] dma-fence: Add boost fence op

2021-05-19 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler that a fence waiter has missed a deadline waiting on the fence. In some cases, missing a vblank can result in lower gpu utilization, when really we want to go in the opposite direction and boost gpu freq. The boost callback gives some