Re: [RFC 3/3] drm/vkms: Implement CRC debugfs API

2018-06-29 Thread Haneen Mohammed
On Thu, Jun 28, 2018 at 01:40:08PM +0200, Daniel Vetter wrote: > On Thu, Jun 28, 2018 at 10:07 AM, Daniel Vetter wrote: > > On Thu, Jun 28, 2018 at 12:24:35AM +0300, Haneen Mohammed wrote: > >> Implement the .set_crc_source() callback. > >> Compute CRC using crc32 on the visible part of the

Re: [RFC 3/3] drm/vkms: Implement CRC debugfs API

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 10:07 AM, Daniel Vetter wrote: > On Thu, Jun 28, 2018 at 12:24:35AM +0300, Haneen Mohammed wrote: >> Implement the .set_crc_source() callback. >> Compute CRC using crc32 on the visible part of the framebuffer. >> Use work_struct to compute and add CRC at the end of a

[RFC 3/3] drm/vkms: Implement CRC debugfs API

2018-06-28 Thread Haneen Mohammed
Implement the .set_crc_source() callback. Compute CRC using crc32 on the visible part of the framebuffer. Use work_struct to compute and add CRC at the end of a vblank. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_crtc.c | 76

Re: [RFC 3/3] drm/vkms: Implement CRC debugfs API

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 10:07:34AM +0200, Daniel Vetter wrote: > On Thu, Jun 28, 2018 at 12:24:35AM +0300, Haneen Mohammed wrote: > > Implement the .set_crc_source() callback. > > Compute CRC using crc32 on the visible part of the framebuffer. > > Use work_struct to compute and add CRC at the end

Re: [RFC 3/3] drm/vkms: Implement CRC debugfs API

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 12:24:35AM +0300, Haneen Mohammed wrote: > Implement the .set_crc_source() callback. > Compute CRC using crc32 on the visible part of the framebuffer. > Use work_struct to compute and add CRC at the end of a vblank. > > Signed-off-by: Haneen Mohammed Ok locking review. I