Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-06 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Fri, Sep 01, 2023 at 02:08:11PM +0200, Geert Uytterhoeven wrote: >> Hi Maxime, >> >> On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: >> > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: >> > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrot

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-06 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 02:08:11PM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: > > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > > > On Wed, Aug 30, 2023

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: >> On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: >> > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: >> > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > > > The commit 45b5866

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > > >

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi > > Am 01.09.23 um 09:48 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Hi Javier, >>> >>> another idea about this patch: why not just keep the allocation in the >>> plane's atomic check, but store the temporary buffers in a p

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Thomas Zimmermann
Hi Am 01.09.23 um 09:48 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hi Javier, another idea about this patch: why not just keep the allocation in the plane's atomic check, but store the temporary buffers in a plane struct. You'd only grow the arrays length in atomic_check and

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Maxime, > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: >> On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: >> > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's >> > .atomic_check() callback") moved the alloc

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Fri, Sep 01, 2023 at 09:48:09AM +0200, Javier Martinez Canillas wrote: >> Thomas Zimmermann writes: >> >> > Hi Javier, >> > >> > another idea about this patch: why not just keep the allocation in the >> > plane's atomic check, but store the temporary buffers in a pla

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > > .atomic_check() callback") moved the allocation of the intermediate and > > HW

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 09:48:09AM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > Hi Javier, > > > > another idea about this patch: why not just keep the allocation in the > > plane's atomic check, but store the temporary buffers in a plane struct. > > You'd only grow

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
Hi, On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > .atomic_check() callback") moved the allocation of the intermediate and > HW buffers from the encoder's .atomic_enable callback to primary plane's

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier, > > another idea about this patch: why not just keep the allocation in the > plane's atomic check, but store the temporary buffers in a plane struct. > You'd only grow the arrays length in atomic_check and later fetch the > pointers in atomic_update. It n

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-31 Thread Thomas Zimmermann
Hi Javier, another idea about this patch: why not just keep the allocation in the plane's atomic check, but store the temporary buffers in a plane struct. You'd only grow the arrays length in atomic_check and later fetch the pointers in atomic_update. It needs some locking, but nothing complic

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-30 Thread Thomas Zimmermann
Hi Geert Am 30.08.23 um 09:40 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, Aug 30, 2023 at 9:08 AM Thomas Zimmermann wrote: Am 30.08.23 um 08:25 schrieb Javier Martinez Canillas: The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") moved the allo

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-30 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Aug 30, 2023 at 9:08 AM Thomas Zimmermann wrote: > Am 30.08.23 um 08:25 schrieb Javier Martinez Canillas: > > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > > .atomic_check() callback") moved the allocation of the intermediate and > > HW buffers from th

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-30 Thread Thomas Zimmermann
Hi Javier Am 30.08.23 um 08:25 schrieb Javier Martinez Canillas: The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") moved the allocation of the intermediate and HW buffers from the encoder's .atomic_enable callback to primary plane's .atomic_check ca

[RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-08-29 Thread Javier Martinez Canillas
The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") moved the allocation of the intermediate and HW buffers from the encoder's .atomic_enable callback to primary plane's .atomic_check callback. This was suggested by Maxime Ripard because drivers aren't