Re: [RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread Christian König
Am 15.06.21 um 17:06 schrieb Felix Kuehling: Am 2021-06-15 um 8:18 a.m. schrieb Christian König: Am 15.06.21 um 14:11 schrieb Pan, Xinhui: 2021年6月15日 20:01,Christian König 写道: Am 15.06.21 um 13:57 schrieb xinhui pan: Amdgpu set SG flag in populate callback. So TTM still count pages in SG

Re: [RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread Felix Kuehling
Am 2021-06-15 um 8:18 a.m. schrieb Christian König: > Am 15.06.21 um 14:11 schrieb Pan, Xinhui: >>> 2021年6月15日 20:01,Christian König >>> 写道: >>> >>> Am 15.06.21 um 13:57 schrieb xinhui pan: Amdgpu set SG flag in populate callback. So TTM still count pages in SG BO. >>> It's

Re: [RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread Christian König
Am 15.06.21 um 14:11 schrieb Pan, Xinhui: 2021年6月15日 20:01,Christian König 写道: Am 15.06.21 um 13:57 schrieb xinhui pan: Amdgpu set SG flag in populate callback. So TTM still count pages in SG BO. It's probably better to fix this instead. E.g. why does amdgpu modify the SG flag during

Re: [RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread Pan, Xinhui
> 2021年6月15日 20:01,Christian König 写道: > > Am 15.06.21 um 13:57 schrieb xinhui pan: >> Amdgpu set SG flag in populate callback. So TTM still count pages in SG >> BO. > > It's probably better to fix this instead. E.g. why does amdgpu modify the SG > flag during populate and not during initial

Re: [RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread Christian König
Am 15.06.21 um 13:57 schrieb xinhui pan: Amdgpu set SG flag in populate callback. So TTM still count pages in SG BO. It's probably better to fix this instead. E.g. why does amdgpu modify the SG flag during populate and not during initial creation? That doesn't seem to make sense.

[RFC PATCH] drm/ttm: Do page counting after populate callback succeed

2021-06-15 Thread xinhui pan
Amdgpu set SG flag in populate callback. So TTM still count pages in SG BO. One easy way to fix this is lets count pages after populate callback. We hit one issue that amdgpu alloc many SG BOs, but TTM try to do swap again and again even if swapout does not swap SG BOs at all. Signed-off-by: