[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-11-04 Thread Christophe Fergeau
On Thu, Nov 03, 2016 at 06:42:38PM +, Emil Velikov wrote: > Hi guys, > > On 2 November 2016 at 16:31, Christophe Fergeau > wrote: > > Hey, > > > > On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: > >> > diff --git a/drivers/gpu/drm/qxl/qxl_display.c > >> > b/drivers/gpu/drm/q

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-11-03 Thread Emil Velikov
Hi guys, On 2 November 2016 at 16:31, Christophe Fergeau wrote: > Hey, > > On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: >> > diff --git a/drivers/gpu/drm/qxl/qxl_display.c >> > b/drivers/gpu/drm/qxl/qxl_display.c >> > index 156b7de..edb90f6 100644 >> > --- a/drivers/gpu/drm/qx

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-11-02 Thread Christophe Fergeau
On Wed, Nov 02, 2016 at 05:31:28PM +0100, Christophe Fergeau wrote: > > > > > + if (client_head->flags != 0) { > > > + client_head->flags = 0; > > > + changed = true; > > > + } > > > > why testing flags change if is always 0 ? > > Yeah, same for su

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-11-02 Thread Christophe Fergeau
Hey, On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c > > b/drivers/gpu/drm/qxl/qxl_display.c > > index 156b7de..edb90f6 100644 > > --- a/drivers/gpu/drm/qxl/qxl_display.c > > +++ b/drivers/gpu/drm/qxl/qxl_display.c > > @@ -57,11 +

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

2016-10-31 Thread Frediano Ziglio
> > When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG > interrupt, > we currently always notify userspace that there was some hotplug event. > > However, gnome-shell/mutter is reacting to this event by attempting a > resolution change, which it does by issueing drmModeRmFB, drmM