Re: [bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2018-06-15 Thread Oleksandr Andrushchenko
On 06/15/2018 12:08 PM, Dan Carpenter wrote: On Fri, Jun 15, 2018 at 08:39:17AM +0300, Oleksandr Andrushchenko wrote: On 06/15/2018 06:22 AM, YoungJun Cho wrote: Dear Dan, Your mail flashes back to my memory 5 years ago. Back then, I had cleaned up the exynos driver. And the replacement

Re: [bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2018-06-15 Thread Dan Carpenter
On Fri, Jun 15, 2018 at 08:39:17AM +0300, Oleksandr Andrushchenko wrote: > On 06/15/2018 06:22 AM, YoungJun Cho wrote: > > Dear Dan, > > > > Your mail flashes back to my memory 5 years ago. > > Back then, I had cleaned up the exynos driver. > > > > And the replacement IS_ERR was one of items. >

Re: [bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2018-06-14 Thread Oleksandr Andrushchenko
On 06/15/2018 06:22 AM, YoungJun Cho wrote: Dear Dan, Your mail flashes back to my memory 5 years ago. Back then, I had cleaned up the exynos driver. And the replacement IS_ERR was one of items. IMHO it is still better to modify those two functions, drm_gem_cma_prime_get_sg_table and

Re: [bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2018-06-14 Thread YoungJun Cho
Dear Dan, Your mail flashes back to my memory 5 years ago. Back then, I had cleaned up the exynos driver. And the replacement IS_ERR was one of items. IMHO it is still better to modify those two functions, drm_gem_cma_prime_get_sg_table and xen_drm_front_gem_get_sg_table. Thank you. Best

[bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2018-06-14 Thread Dan Carpenter
Hello YoungJun Cho, The patch 7e3d88f9cce3: "drm/prime: replace NULL with error value in drm_prime_pages_to_sg" from Jun 24, 2013, leads to the following static checker warning: drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf() warn: 'sgt' can also be NULL