[Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-07 Thread Dave Airlie
On 4 November 2016 at 20:41, Christophe Fergeau wrote: > On Thu, Nov 03, 2016 at 06:08:39PM +0100, Gerd Hoffmann wrote: >> > Or maybe other parts of the >> > kernel/userspace rely on this rounding down. >> >> This is where I suspect we could run in trouble. Odd resolutions simply >> don't happen

[Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-07 Thread Gerd Hoffmann
Hi, > I think we should try it an see, Ok, lets try. I'll go pick them up and prepare a pull with this and some virtio-gpu bits, Gerd

[Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-04 Thread Christophe Fergeau
On Thu, Nov 03, 2016 at 06:08:39PM +0100, Gerd Hoffmann wrote: > > Or maybe other parts of the > > kernel/userspace rely on this rounding down. > > This is where I suspect we could run in trouble. Odd resolutions simply > don't happen on physical hardware, all usual resolutions are a multiple >

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-03 Thread Gerd Hoffmann
On Do, 2016-11-03 at 12:41 +0100, Christophe Fergeau wrote: > On Thu, Nov 03, 2016 at 09:53:48AM +0100, Gerd Hoffmann wrote: > > On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > > > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > > > the resolutions we are

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-03 Thread Christophe Fergeau
On Thu, Nov 03, 2016 at 09:53:48AM +0100, Gerd Hoffmann wrote: > On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > > the resolutions we are going to present to user-space are going to be > > rounded down to a

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-03 Thread Gerd Hoffmann
On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > the resolutions we are going to present to user-space are going to be > rounded down to a multiple of 8. In the QXL arbitrary resolution case, > this is not

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-02 Thread Christophe Fergeau
The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that the resolutions we are going to present to user-space are going to be rounded down to a multiple of 8. In the QXL arbitrary resolution case, this is not useful. This commit forces the actual width/height that was requested by