tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head:   2bdb481bf7a93c22b9fea8daefa2834aab23a70f
commit: b0f0469ab662159f182f5af292b71cc5d42468a8 [4/6] drm: xlnx: zynqmp_dpsub: 
Anounce supported input formats
config: i386-buildonly-randconfig-006-20240426 
(https://download.01.org/0day-ci/archive/20240426/202404260800.7uecbp6c-...@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 
6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20240426/202404260800.7uecbp6c-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202404260800.7uecbp6c-...@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/xlnx/zynqmp_disp.c:949:14: warning: logical not is only 
>> applied to the left hand side of this comparison [-Wlogical-not-parentheses]
     949 |         if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
         |                     ^            ~~
   include/asm-generic/bug.h:123:25: note: expanded from macro 'WARN_ON'
     123 |         int __ret_warn_on = !!(condition);                           
   \
         |                                ^~~~~~~~~
   drivers/gpu/drm/xlnx/zynqmp_disp.c:949:14: note: add parentheses after the 
'!' to evaluate the comparison first
   drivers/gpu/drm/xlnx/zynqmp_disp.c:949:14: note: add parentheses around left 
hand side expression to silence this warning
   1 warning generated.


vim +949 drivers/gpu/drm/xlnx/zynqmp_disp.c

   928  
   929  /**
   930   * zynqmp_disp_layer_drm_formats - Return the DRM formats supported by 
the layer
   931   * @layer: The layer
   932   * @num_formats: Pointer to the returned number of formats
   933   *
   934   * NOTE: This function doesn't make sense for live video layers and will
   935   * always return an empty list in such cases. 
zynqmp_disp_live_layer_formats()
   936   * should be used to query a list of media bus formats supported by the 
live
   937   * video input layer.
   938   *
   939   * Return: A newly allocated u32 array that stores all the DRM formats
   940   * supported by the layer. The number of formats in the array is 
returned
   941   * through the num_formats argument.
   942   */
   943  u32 *zynqmp_disp_layer_drm_formats(struct zynqmp_disp_layer *layer,
   944                                     unsigned int *num_formats)
   945  {
   946          unsigned int i;
   947          u32 *formats;
   948  
 > 949          if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
   950                  *num_formats = 0;
   951                  return NULL;
   952          }
   953  
   954          formats = kcalloc(layer->info->num_formats, sizeof(*formats),
   955                            GFP_KERNEL);
   956          if (!formats) {
   957                  *num_formats = 0;
   958                  return NULL;
   959          }
   960  
   961          for (i = 0; i < layer->info->num_formats; ++i)
   962                  formats[i] = layer->info->formats[i].drm_fmt;
   963  
   964          *num_formats = layer->info->num_formats;
   965          return formats;
   966  }
   967  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to