[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-13 Thread Sergej Pupykin
At Mon, 13 Dec 2010 13:43:48 +0300, Sergej Pupykin wrote: > video="9-pin DIN:1024x768-24 at 60e", but lilo uses doublequotes as > r-value bounds. > > in_quote variable in next_arg() is set only for " character. Sorry, biggest part of this problem is in my linux distribution (in /init

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-13 Thread Sergej Pupykin
At Fri, 10 Dec 2010 19:05:13 +0100, Peter Stuge wrote: > append can contain any arbitrary string, which will be parsed by the > kernel. I e.g. use: > > append="root=/dev/sda2 snd_ac97_codec.power_save=1 usbcore.autosuspend=1 > hpet=force quiet drm_kms_helper.poll=0" > > And grub also supports an

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-13 Thread Sergej Pupykin
At Fri, 10 Dec 2010 19:05:13 +0100, Peter Stuge pe...@stuge.se wrote: append can contain any arbitrary string, which will be parsed by the kernel. I e.g. use: append=root=/dev/sda2 snd_ac97_codec.power_save=1 usbcore.autosuspend=1 hpet=force quiet drm_kms_helper.poll=0 And grub also

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-13 Thread Sergej Pupykin
At Mon, 13 Dec 2010 13:43:48 +0300, Sergej Pupykin m...@sergej.pp.ru wrote: video=9-pin DIN:1024x768...@60e, but lilo uses doublequotes as r-value bounds. in_quote variable in next_arg() is set only for character. Sorry, biggest part of this problem is in my linux distribution (in /init

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-10 Thread Peter Stuge
Sergej Pupykin wrote: > > And it's ugly; can't we fix grub instead? > > I am searching for bootloader which can pass whitespaces. It looks > like we should patch grub-legacy (0.97), grub (1.98) and lilo... > > (I did not try lilo yet, but man page says nothing about passing > spaces in 'append='

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-10 Thread Sergej Pupykin
At Thu, 9 Dec 2010 09:18:14 -0800, Jesse Barnes wrote: > > And it's ugly; can't we fix grub instead? I am searching for bootloader which can pass whitespaces. It looks like we should patch grub-legacy (0.97), grub (1.98) and lilo... (I did not try lilo yet, but man page says nothing about

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-10 Thread Sergej Pupykin
At Thu, 9 Dec 2010 09:18:14 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: And it's ugly; can't we fix grub instead? I am searching for bootloader which can pass whitespaces. It looks like we should patch grub-legacy (0.97), grub (1.98) and lilo... (I did not try lilo yet, but man page

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-10 Thread Peter Stuge
Sergej Pupykin wrote: And it's ugly; can't we fix grub instead? I am searching for bootloader which can pass whitespaces. It looks like we should patch grub-legacy (0.97), grub (1.98) and lilo... (I did not try lilo yet, but man page says nothing about passing spaces in 'append=' option

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Peter Stuge
Jesse Barnes wrote: > An alternative to fixing grub would be to add aliases like you mention, > and/or change the parser to accept "_" as an alias for " ". Then we > could leave the sysfs values and string table alone. Is it already case insensitive? //Peter

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Sergej Pupykin
At Thu, 9 Dec 2010 09:18:14 -0800, Jesse Barnes wrote: > > On Wed, 8 Dec 2010 15:30:26 -0800 > Greg KH wrote: > > What kernel version did these options first show up in? Does any > > other tools rely on the spaces? > > And it's ugly; can't we fix grub instead? I think renaming connectors is

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Jesse Barnes
On Thu, 09 Dec 2010 20:33:18 +0300 Sergej Pupykin wrote: > At Thu, 9 Dec 2010 09:18:14 -0800, > Jesse Barnes wrote: > > > > On Wed, 8 Dec 2010 15:30:26 -0800 > > Greg KH wrote: > > > What kernel version did these options first show up in? Does any > > > other tools rely on the spaces? > > >

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Dave Airlie
On Thu, Dec 9, 2010 at 9:30 AM, Greg KH wrote: > On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: >> Grub doesn't parse spaces in parameters correctly, so >> this makes it impossible to force video= parameters >> for kms on the grub kernel command line. >> >> Reported-by: Sergej

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Jesse Barnes
On Wed, 8 Dec 2010 15:30:26 -0800 Greg KH wrote: > On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: > > Grub doesn't parse spaces in parameters correctly, so > > this makes it impossible to force video= parameters > > for kms on the grub kernel command line. > > > > Reported-by:

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Jesse Barnes
On Wed, 8 Dec 2010 15:30:26 -0800 Greg KH g...@kroah.com wrote: On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: Grub doesn't parse spaces in parameters correctly, so this makes it impossible to force video= parameters for kms on the grub kernel command line. Reported-by:

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Sergej Pupykin
At Thu, 9 Dec 2010 09:18:14 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 8 Dec 2010 15:30:26 -0800 Greg KH g...@kroah.com wrote: What kernel version did these options first show up in? Does any other tools rely on the spaces? And it's ugly; can't we fix grub instead? I

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-09 Thread Peter Stuge
Jesse Barnes wrote: An alternative to fixing grub would be to add aliases like you mention, and/or change the parser to accept _ as an alias for . Then we could leave the sysfs values and string table alone. Is it already case insensitive? //Peter

[stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-08 Thread Greg KH
On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: > Grub doesn't parse spaces in parameters correctly, so > this makes it impossible to force video= parameters > for kms on the grub kernel command line. > > Reported-by: Sergej Pupykin > > Cc: Sergej Pupykin > Signed-off-by: Alex

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-08 Thread Greg KH
On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: Grub doesn't parse spaces in parameters correctly, so this makes it impossible to force video= parameters for kms on the grub kernel command line. Reported-by: Sergej Pupykin m...@sergej.pp.ru Cc: Sergej Pupykin

Re: [stable] [PATCH] drm/kms: remove spaces from connector names

2010-12-08 Thread Dave Airlie
On Thu, Dec 9, 2010 at 9:30 AM, Greg KH g...@kroah.com wrote: On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote: Grub doesn't parse spaces in parameters correctly, so this makes it impossible to force video= parameters for kms on the grub kernel command line. Reported-by: Sergej