Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-21 Thread Ondřej Jirman
Hello, On Thu, Apr 19, 2018 at 04:02:08PM +0200, Giulio Benetti wrote: > Hi everybody, > > Il 19/04/2018 15:36, Chen-Yu Tsai ha scritto: > > On Thu, Apr 19, 2018 at 9:34 PM, Ondřej Jirman > > wrote: > > > Hello Giulio, > > > > > > this patch breaks LVDS output on

Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-20 Thread Maxime Ripard
On Fri, Apr 20, 2018 at 03:10:26PM +0200, Ondřej Jirman wrote: > Hello, > > On Thu, Apr 19, 2018 at 04:02:08PM +0200, Giulio Benetti wrote: > > Hi everybody, > > > > Il 19/04/2018 15:36, Chen-Yu Tsai ha scritto: > > > On Thu, Apr 19, 2018 at 9:34 PM, Ondřej Jirman > > >

Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-20 Thread Ondřej Jirman
Hello Giulio, this patch breaks LVDS output on A83T. Without it, modesetting works, with it there's no output. Some more info below... On Tue, Mar 13, 2018 at 12:20:19PM +0100, Giulio Benetti wrote: > mode_valid function is missing for lvds. > > Add it making it pointed by encoder helper

Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-19 Thread Giulio Benetti
Hi everybody, Il 19/04/2018 15:36, Chen-Yu Tsai ha scritto: On Thu, Apr 19, 2018 at 9:34 PM, Ondřej Jirman wrote: Hello Giulio, this patch breaks LVDS output on A83T. Without it, modesetting works, with it there's no output. Some more info below... On Tue, Mar

Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-19 Thread Chen-Yu Tsai
On Thu, Apr 19, 2018 at 9:34 PM, Ondřej Jirman wrote: > Hello Giulio, > > this patch breaks LVDS output on A83T. Without it, modesetting works, > with it there's no output. > > Some more info below... > > On Tue, Mar 13, 2018 at 12:20:19PM +0100, Giulio Benetti wrote:

Re: [PATCH v2] drm/sun4i: add lvds mode_valid function

2018-03-14 Thread Maxime Ripard
On Tue, Mar 13, 2018 at 12:20:19PM +0100, Giulio Benetti wrote: > mode_valid function is missing for lvds. > > Add it making it pointed by encoder helper functions. > > Signed-off-by: Giulio Benetti Applied, thanks! Maxime -- Maxime Ripard, Bootlin (formerly

[PATCH v2] drm/sun4i: add lvds mode_valid function

2018-03-13 Thread Giulio Benetti
mode_valid function is missing for lvds. Add it making it pointed by encoder helper functions. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_lvds.c | 55 ++ 1 file changed, 55 insertions(+) diff --git