Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-11 Thread Linus Torvalds
On Mon, Jun 11, 2018 at 12:07 AM Christoph Hellwig wrote: > > For now I'd say revert this commit for 4.17/4.18-rc and I'll look into > addressing these issues properly. Ok, reverted in my tree, and marked for stable (for 4.17). Thanks, Linus

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-11 Thread Gabriel C
2018-06-08 8:52 GMT+02:00 Christian König : > Am 08.06.2018 um 08:02 schrieb Christoph Hellwig: >> >> On Thu, Jun 07, 2018 at 02:32:46PM +0200, Gabriel C wrote: >>> >>> Ok done.. bisect points to: >> >> What is the failure mode you are seeing? Can't find anything in the >> mail unfortunately. > >

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-11 Thread Christoph Hellwig
I think the prime issue is that dma_direct_alloc respects the dma mask. Which we don't need if actually using the iommu. This would be mostly harmless exept for the the SEV bit high in the address that makes the checks fail. For now I'd say revert this commit for 4.17/4.18-rc and I'll look into

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-08 Thread Gabriel C
2018-06-07 9:07 GMT+02:00 Christian König : > Am 06.06.2018 um 17:44 schrieb Gabriel C: >> >> 2018-06-06 17:03 GMT+02:00 Michel Dänzer : >>> >>> On 2018-06-06 04:44 PM, Christian König wrote: Am 06.06.2018 um 16:12 schrieb Michel Dänzer: [SNIP] At least in theory it should work

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-08 Thread Gabriel C
>> Well that is very interesting, you are the first one who reports that SME + >> GFX works in some way. So far we only got negative reports for that. >> >>> There is a 4.16.13 boot dmesg which has no such issue: >>> >>> >>>

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-08 Thread Christian König
Am 08.06.2018 um 08:02 schrieb Christoph Hellwig: On Thu, Jun 07, 2018 at 02:32:46PM +0200, Gabriel C wrote: Ok done.. bisect points to: What is the failure mode you are seeing? Can't find anything in the mail unfortunately. As far as I analyzed it we now get an -ENOMEM from

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-08 Thread Christian König
Hi Christoph, Am 08.06.2018 um 08:01 schrieb Christoph Hellwig: On Thu, Jun 07, 2018 at 07:20:37PM +0200, Christian König wrote: Hi Christopher, I don't see a Christopher on the Cc list.. Sorry, auto-uncorrection. I indeed meant you :) Christian.

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Christoph Hellwig
On Thu, Jun 07, 2018 at 02:32:46PM +0200, Gabriel C wrote: > Ok done.. bisect points to: What is the failure mode you are seeing? Can't find anything in the mail unfortunately. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Christoph Hellwig
On Thu, Jun 07, 2018 at 07:20:37PM +0200, Christian König wrote: > Hi Christopher, I don't see a Christopher on the Cc list.. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Christian König
Hi Christopher, Am 07.06.2018 um 18:24 schrieb Gabriel C: [SNIP] Ok done.. bisect points to: b468620f2a1dfdcfddfd6fa54367b8bcc1b51248 is the first bad commit commit b468620f2a1dfdcfddfd6fa54367b8bcc1b51248 Author: Christoph Hellwig Date: Mon Mar 19 11:38:19 2018 +0100 iommu/amd_iommu:

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Christian König
Am 06.06.2018 um 17:44 schrieb Gabriel C: 2018-06-06 17:03 GMT+02:00 Michel Dänzer : On 2018-06-06 04:44 PM, Christian König wrote: Am 06.06.2018 um 16:12 schrieb Michel Dänzer: [SNIP] At least in theory it should work when we use the coherent DMA allocator. When that really worked before, so

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Gabriel C
2018-06-06 17:03 GMT+02:00 Michel Dänzer : > On 2018-06-06 04:44 PM, Christian König wrote: >> Am 06.06.2018 um 16:12 schrieb Michel Dänzer: >>> On 2018-06-06 03:33 PM, Gabriel C wrote: 2018-06-06 14:19 GMT+02:00 Christian König : > Am 06.06.2018 um 14:08 schrieb Gabriel C: >>

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Gabriel C
2018-06-06 14:19 GMT+02:00 Christian König : > Am 06.06.2018 um 14:08 schrieb Gabriel C: >> >> 2018-06-06 13:33 GMT+02:00 Christian König : >>> >>> Am 06.06.2018 um 13:28 schrieb Gabriel C: 2018-04-11 7:02 GMT+02:00 Gabriel C : >> >> 2018-04-11 6:00 GMT+02:00 Gabriel C : >>

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-07 Thread Gabriel C
2018-06-06 16:44 GMT+02:00 Christian König : > Am 06.06.2018 um 16:12 schrieb Michel Dänzer: >> >> On 2018-06-06 03:33 PM, Gabriel C wrote: >>> >>> 2018-06-06 14:19 GMT+02:00 Christian König : Am 06.06.2018 um 14:08 schrieb Gabriel C: > > 2018-06-06 13:33 GMT+02:00 Christian

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-06 Thread Michel Dänzer
On 2018-06-06 04:44 PM, Christian König wrote: > Am 06.06.2018 um 16:12 schrieb Michel Dänzer: >> On 2018-06-06 03:33 PM, Gabriel C wrote: >>> 2018-06-06 14:19 GMT+02:00 Christian König : Am 06.06.2018 um 14:08 schrieb Gabriel C: > 2018-06-06 13:33 GMT+02:00 Christian König : >> Am

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-06 Thread Christian König
Am 06.06.2018 um 16:12 schrieb Michel Dänzer: On 2018-06-06 03:33 PM, Gabriel C wrote: 2018-06-06 14:19 GMT+02:00 Christian König : Am 06.06.2018 um 14:08 schrieb Gabriel C: 2018-06-06 13:33 GMT+02:00 Christian König : Am 06.06.2018 um 13:28 schrieb Gabriel C: 2018-04-11 7:02 GMT+02:00

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-06 Thread Christian König
Am 06.06.2018 um 15:33 schrieb Gabriel C: 2018-06-06 14:19 GMT+02:00 Christian König : Am 06.06.2018 um 14:08 schrieb Gabriel C: [SNIP] That has nothing TODO with the driver nor the original bug you reported. The problem is that SME is active and that is currently not supported at all with a

Re: Kernel and ADM hardware roulette ( was AMD graphics performance regression in 4.15 and later )

2018-06-06 Thread Michel Dänzer
On 2018-06-06 03:33 PM, Gabriel C wrote: 2018-06-06 14:19 GMT+02:00 Christian König : Am 06.06.2018 um 14:08 schrieb Gabriel C: 2018-06-06 13:33 GMT+02:00 Christian König : Am 06.06.2018 um 13:28 schrieb Gabriel C: 2018-04-11 7:02 GMT+02:00 Gabriel C : [6.337838] [drm] PCIE GART of