Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2023-01-05 Thread Daniel Vetter
On Tue, Dec 13, 2022 at 07:17:41PM +0100, Christian König wrote: > Am 13.12.22 um 18:09 schrieb Daniel Vetter: > > On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > > > Hi Christian, > > > > > > On Fri, 9 Dec 2022 at 12:45, Christian König > > > wrote: > > > > The init order and

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Christian König
Am 13.12.22 um 18:09 schrieb Daniel Vetter: On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: Hi Christian, On Fri, 9 Dec 2022 at 12:45, Christian König wrote: The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Daniel Vetter
On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > Hi Christian, > > On Fri, 9 Dec 2022 at 12:45, Christian König > wrote: > > > > The init order and resulting error handling in dma_buf_export > > was pretty messy. > > > > Subordinate objects like the file and the sysfs kernel

Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread Sumit Semwal
Hi Christian, On Fri, 9 Dec 2022 at 12:45, Christian König wrote: > > The init order and resulting error handling in dma_buf_export > was pretty messy. > > Subordinate objects like the file and the sysfs kernel objects > were initializing and wiring itself up with the object in the > wrong order

Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread T.J. Mercier
On Fri, Dec 9, 2022 at 8:29 AM Ruhl, Michael J wrote: > > >-Original Message- > >From: dri-devel On Behalf Of > >Christian König > >Sent: Friday, December 9, 2022 2:16 AM > >To: quic_chara...@quicinc.com; cuigaoshe...@huawei.com; > >sumit.sem...@linaro.org > >Cc:

RE: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Friday, December 9, 2022 2:16 AM >To: quic_chara...@quicinc.com; cuigaoshe...@huawei.com; >sumit.sem...@linaro.org >Cc: linaro-mm-...@lists.linaro.org; dri-devel@lists.freedesktop.org; linux- >me...@vger.kernel.org

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on v6.1-rc8] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next next-20221206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on v6.1-rc8] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next next-20221206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread T.J. Mercier
On Tue, Dec 6, 2022 at 7:12 AM Christian König wrote: > > The init order and resulting error handling in dma_buf_export > was pretty messy. > > Subordinate objects like the file and the sysfs kernel objects > were initializing and wiring itself up with the object in the > wrong order resulting

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Christian König
Am 06.12.22 um 17:20 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Christian König Sent: Tuesday, December 6, 2022 10:12 AM To: quic_chara...@quicinc.com; cuigaoshe...@huawei.com; tjmerc...@google.com; sumit.sem...@linaro.org Cc:

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Charan Teja Kalla
Thanks Christian for this nice cleanup!! On 12/6/2022 8:42 PM, Christian König wrote: > @@ -638,10 +630,21 @@ struct dma_buf *dma_buf_export(const struct > dma_buf_export_info *exp_info) > if (!try_module_get(exp_info->owner)) > return ERR_PTR(-ENOENT); > > + file =

RE: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Tuesday, December 6, 2022 10:12 AM >To: quic_chara...@quicinc.com; cuigaoshe...@huawei.com; >tjmerc...@google.com; sumit.sem...@linaro.org >Cc: linaro-mm-...@lists.linaro.org; dri-devel@lists.freedesktop.org; linux-