RE: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-31 Thread Flavio Suligoi
Hi Krzysztof, ... > >>> + > >>> + reg: > >>> +maxItems: 1 > >>> + > >>> + mps,dimming-mode: > >>> +description: The dimming mode (PWM or analog by I2C commands). > >>> +$ref: '/schemas/types.yaml#/definitions/string' > >> > >> Drop quotes, you should see warnings for this. > >> > >>

RE: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-30 Thread Flavio Suligoi
Hi Krzysztof, Thanks for your quick replay and corrections! Just some questions about some of your remarks: > > @@ -0,0 +1,202 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > > + > > + reg: > > +maxItems: 1 > > + > > + mps,dimming-mode: > > +descript

Re: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-29 Thread Krzysztof Kozlowski
On 29/08/2023 16:18, Flavio Suligoi wrote: > Hi Krzysztof, > > Thanks for your quick replay and corrections! > Just some questions about some of your remarks: > >>> @@ -0,0 +1,202 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 >>> +--- >> >>> + >>> + reg: >>> +maxItem

Re: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-29 Thread Krzysztof Kozlowski
On 29/08/2023 12:15, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM input signal (PWM mode).