RE: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-27 Thread Yuti Suresh Amonkar
airl...@linux.ie; dan...@ffwll.ch; mark.rutl...@arm.com; > a.ha...@samsung.com; narmstr...@baylibre.com; jo...@kwiboo.se; > jernej.skra...@siol.net; prane...@ti.com; jsa...@ti.com; > tomi.valkei...@ti.com; Milind Parab ; Swapnil > Kashinath Jakhade > Subject: Re: [PATCH v6 2/3] drm:

Re: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-10 Thread Laurent Pinchart
Hi Tomi, Daniel, On Thu, Mar 12, 2020 at 09:13:06AM +0200, Tomi Valkeinen wrote: > On 12/03/2020 00:20, Laurent Pinchart wrote: > >> + ret = load_firmware(mhdp); > >> + if (ret) > >> + goto phy_exit; > >> + > >> + drm_bridge_add(>bridge); > > > What if someone starts using the bridge

Re: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-10 Thread Laurent Pinchart
Hi Yuti, On Fri, May 01, 2020 at 07:32:58AM +, Yuti Suresh Amonkar wrote: > Hi Laurent, > > Thank you so much for reviewing the patch and providing valuable > comments. Apologies for the delayed response. We are working on your > review comments and will send the next version of the driver

RE: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-05-02 Thread Yuti Suresh Amonkar
gt; airl...@linux.ie; dan...@ffwll.ch; mark.rutl...@arm.com; > a.ha...@samsung.com; narmstr...@baylibre.com; jo...@kwiboo.se; > jernej.skra...@siol.net; prane...@ti.com; jsa...@ti.com; > tomi.valkei...@ti.com; Milind Parab ; Swapnil > Kashinath Jakhade > Subject: Re: [PATCH v6 2/3] d

Re: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-03-12 Thread Tomi Valkeinen
Hi Laurent, On 12/03/2020 00:20, Laurent Pinchart wrote: + ret = load_firmware(mhdp); + if (ret) + goto phy_exit; + + drm_bridge_add(>bridge); What if someone starts using the bridge before the firmware is operational ? It seems that you should delay bridge

Re: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-03-11 Thread Laurent Pinchart
Hi Yuti, Thank you for the patch. On Wed, Feb 26, 2020 at 11:22:58AM +0100, Yuti Amonkar wrote: > This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. s/DRM driver/DRM bridge driver. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded